fix: solidity native compile diff checks #15312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momentmaker
previously approved these changes
Nov 19, 2024
|
Would it be a little cleaner to install diff-so-fancy somewhere else? e.g. |
erikburt
force-pushed
the
fix/solidity-native-compile
branch
2 times, most recently
from
55ccee4 to
ac92504
Compare
jmank88
approved these changes
Nov 20, 2024
momentmaker
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
chainlinkanddiff-so-fancyrepositories side-by-side so they're not nested.Motivation
#15258 broke the diff check, because
diff-so-fancyis being used and is checked out inside the cwd, it gets added and thengit diffreturns a 1.Testing