Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test_GetWrappedNativeTokenPriceUSD #15316

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

asoliman92
Copy link
Contributor

No description provided.

@asoliman92 asoliman92 requested a review from a team as a code owner November 19, 2024 19:08
@asoliman92 asoliman92 requested review from winder, rstout, makramkd, dimkouv, mateusz-sekara, 0xAustinWang and 0xnogo and removed request for a team November 19, 2024 19:08
Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Root Project / Find Tests To Run , Core Tests (go_core_tests) , lint , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests... , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. File is not goimports-ed with -local github.com/smartcontractkit/chainlink:[Golang Lint]

Source of Error:
Golang Lint	2024-11-19T19:14:46.6432586Z core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go:6: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint	2024-11-19T19:14:46.6435377Z 	"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/router"

Why: The error indicates that the file ccipreader_test.go is not formatted according to the goimports tool with the -local flag set to github.com/smartcontractkit/chainlink. This means the import statements in the file are not organized as expected.

Suggested fix: Run goimports -local github.com/smartcontractkit/chainlink -w core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go to automatically format the import statements in the file correctly.

@asoliman92 asoliman92 merged commit d365669 into ccipreader-tests Nov 20, 2024
43 checks passed
@asoliman92 asoliman92 deleted the native-token-price branch November 20, 2024 12:37
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
* Add Test_GetChainFeePriceUpdates (#15240)

Add Test_GetChainFeePriceUpdates

* Bind real contracts per chain in CCIPReader test (#15282)

Add functionality to bind more contracts to different chains (using same simulated backend for simplicity) in ccipreader tester.

LinkPriceUSD test
GetMedianDataAvailabilityGasConfig

* Test_GetWrappedNativeTokenPriceUSD (#15316)

Test_GetWrappedNativeTokenPriceUSD

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants