CCIP-4331 update factory contract to use new arbitrary token decimals in constructor #15337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
RensR
force-pushed
the
CCIP-4156-solana-compatible-pools
branch
from
c67cf0d to
1733801
Compare
Base automatically changed from
CCIP-4156-solana-compatible-pools
to
CCIP-4269-make-pools-swappable
November 22, 2024 14:08
An error occurred while trying to automatically change base from
CCIP-4156-solana-compatible-pools
to
CCIP-4269-make-pools-swappable
November 22, 2024 14:08
…ry_differentDecimals
RensR
approved these changes
Nov 22, 2024
jhweintraub
changed the title
RensR
merged commit 1bd10fb
into
CCIP-4269-make-pools-swappable
124 of 125 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* store hash of (dest chain selector, remote pool) to do lookup * fill in coverage gaps and fix zero address check * remove comment * Update gethwrappers * reduce test code * add test multiple remote pools * improve tests * rename and rm EVM specific checks * [Bot] Update changeset file with jira issues * fix offchain tests * use mapping over set * move remotePools mapping to RemoteChainConfig * use bytes32 set over bytes mapping * fix ci * allow multiple pools on remote chain config * support different decimals (#15310) * use calldata over memory, extract isRemotePool * support different decimals * pass in decimals * add tests * fix liqman, tests, gen code * fix offchain * add comment, changeset and fix lint * turn off 1.4 test * CCIP-4331 update factory contract to use new arbitrary token decimals in constructor (#15337) * support different decimals * pass in decimals * add tests * gen wrappers * update factory contract to use new arbitrary token decimals in constructor * snapshot fix --------- Co-authored-by: Rens Rooimans <github@rensrooimans.nl> --------- Co-authored-by: Rens Rooimans <github@rensrooimans.nl> Co-authored-by: Josh <josh.weintraub@smartcontract.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Josh Weintraub <26035072+jhweintraub@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* store hash of (dest chain selector, remote pool) to do lookup * fill in coverage gaps and fix zero address check * remove comment * Update gethwrappers * reduce test code * add test multiple remote pools * improve tests * rename and rm EVM specific checks * [Bot] Update changeset file with jira issues * fix offchain tests * use mapping over set * move remotePools mapping to RemoteChainConfig * use bytes32 set over bytes mapping * fix ci * allow multiple pools on remote chain config * support different decimals (#15310) * use calldata over memory, extract isRemotePool * support different decimals * pass in decimals * add tests * fix liqman, tests, gen code * fix offchain * add comment, changeset and fix lint * turn off 1.4 test * CCIP-4331 update factory contract to use new arbitrary token decimals in constructor (#15337) * support different decimals * pass in decimals * add tests * gen wrappers * update factory contract to use new arbitrary token decimals in constructor * snapshot fix --------- Co-authored-by: Rens Rooimans <github@rensrooimans.nl> --------- Co-authored-by: Rens Rooimans <github@rensrooimans.nl> Co-authored-by: Josh <josh.weintraub@smartcontract.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Josh Weintraub <26035072+jhweintraub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the token pool factory to support existing PR where newly modified token pools have an additional constructor parameter for token decimals.
PR #15310