testdata/scripts/nodes/evm/list: add test; common/client: fix names in multinode state map #15339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
BCF-3430-nodes-notloaded
branch
from
c055679 to
5b1d243
Compare
jmank88
commented
Nov 20, 2024
| @@ -387,7 +387,7 @@ require ( | |||
| github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475 // indirect | |||
| github.com/rivo/uniseg v0.4.4 // indirect | |||
| github.com/robfig/cron/v3 v3.0.1 // indirect | |||
| github.com/rogpeppe/go-internal v1.12.0 // indirect | |||
| github.com/rogpeppe/go-internal v1.13.1 // indirect | |||
There was a problem hiding this comment.
There was a bug causing failure when the test actually passed.
jmank88
commented
Nov 20, 2024
| } | ||
| for _, n := range c.sendOnlyNodes { | ||
| states[n.String()] = n.State().String() | ||
| states[n.Name()] = n.State().String() |
There was a problem hiding this comment.
String() is Name+URL+State
samsondav
previously approved these changes
Nov 20, 2024
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
jmank88
force-pushed
the
BCF-3430-nodes-notloaded
branch
from
5b1d243 to
611d80b
Compare
vyzaldysanchez
previously approved these changes
Nov 20, 2024
jmank88
changed the title
jmank88
force-pushed
the
BCF-3430-nodes-notloaded
branch
from
611d80b to
72f423d
Compare
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
…n multinode state map
jmank88
force-pushed
the
BCF-3430-nodes-notloaded
branch
from
72f423d to
70718be
Compare
chudilka1
approved these changes
Nov 21, 2024
DylanTinianov
approved these changes
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-3430