(fix): Be more permissive during retries in workflow remote execution initialization

[justinkaseman]

No description provided.

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[krehermann]

imo easier to read if log and return and fall thru

if _, exists := ....; exists {
log.Debug
return nil
}
c.foo = bar

[justinkaseman]

Fair. I don't have a strong opinion, so I'll change it

[github-actions]

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan

1. Test failures encountered: go_core_tests

Source of Error:

Run tests	2024-11-21T02:01:07.8708621Z Encountered test failures.
Run tests	2024-11-21T02:01:07.8709173Z go_core_tests exiting with code 1
Run tests	2024-11-21T02:01:07.8729178Z ##[error]Process completed with exit code 1.

Why: The error indicates that the Go core tests encountered failures during execution. The exit code 1 signifies that at least one test did not pass, causing the job to fail.

Suggested fix: Review the test output logs to identify which specific tests failed and address the underlying issues in the code or test cases. Ensure all tests pass before re-running the action.

[bolekk]

I'm afraid this is not enough :(

See my Slack message and the proposed alternative fix: https://github.com/smartcontractkit/chainlink/pull/15352/files

[justinkaseman]

Closing for @ettec's larger rework