Use real deployed contracts in CCIPReader tests [CCIP-4239] #15357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asoliman92
commented
Nov 21, 2024
•
asoliman92
commented
- Moved tests under ccip smoke tests
- Using real contracts for tests that makes sense to do so. (any tests that don't need offRamp commit/exec reports to be called)
- Added respect finality test
asoliman92
requested review from
EasterTheBunny,
winder,
rstout,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
* Test_LinkPriceUSD * Test_GetChainFeePriceUpdates
* Test_GetMedianDataAvailabilityGasConfig Clean unused functions
* TestCCIPReader_GetExpectedNextSequenceNumber
makramkd
reviewed
Nov 21, 2024
core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go
Outdated
Show resolved
Hide resolved
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
previously approved these changes
Nov 29, 2024
RensR
previously approved these changes
Nov 29, 2024
scheibinger
previously approved these changes
Nov 29, 2024
0xnogo
previously approved these changes
Nov 29, 2024
skudasov
previously approved these changes
Nov 29, 2024
asoliman92
dismissed stale reviews from skudasov, 0xnogo, scheibinger, RensR, and makramkd
via
acf744d
0xnogo
previously approved these changes
Nov 29, 2024
skudasov
approved these changes
Nov 29, 2024
0xsuryansh
approved these changes
Nov 29, 2024
chainchad
approved these changes
Nov 29, 2024
makramkd
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.