Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and optimized Solana TXM error parsing and storage #15369

Merged

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Nov 21, 2024

NONEVM-957

  • Introduced a new OnPrebroadcastError method to the in-memory storage to directly put transactions into the errored state. Previously a transaction had to transition from another state to errored.
  • Separated error parsing and status transition methods so errors can be more easily categorized and handled in both simulation or confirmation
  • Introduced a smaller struct for storing finalized or errored statuses to minimize memory usage in cases of long retention timeouts
  • Introduced a new FatallyErrored status to classify specific Solana errors that should not be retried by plugin side code. Changes to parse and classify errors with this status will be introduced in a later update.

Solana PR: smartcontractkit/chainlink-solana#936

@amit-momin amit-momin requested review from a team as code owners November 21, 2024 19:28
Copy link
Contributor

github-actions bot commented Nov 21, 2024

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Flakeguard Deployment Project , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. File not found error:Tests Summary

Source of Error:
/home/runner/work/_temp/1d6be71a-a60c-4215-aa4c-4f300c4f5fe2.sh: line 1: all_tests.md: No such file or directory

Why: The script is attempting to access a file named all_tests.md, but this file does not exist in the specified directory. This results in a "No such file or directory" error.

Suggested fix: Ensure that all_tests.md is generated or placed in the correct directory before this script runs. You can add a step to check for the file's existence or create it if it does not exist.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

silaslenihan
silaslenihan previously approved these changes Nov 26, 2024
Farber98
Farber98 previously approved these changes Nov 26, 2024
jmank88
jmank88 previously approved these changes Nov 26, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@amit-momin amit-momin dismissed stale reviews from jmank88, Farber98, and silaslenihan via 27f786e December 2, 2024 17:40
Copy link
Contributor

@jmank88 jmank88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really just a changeset now?

@jmank88 jmank88 enabled auto-merge December 2, 2024 19:03
@amit-momin
Copy link
Contributor Author

Is this really just a changeset now?

This PR was just to update the chainlink-solana tag to e68ee4cee85e2e20647ed9d3d6a22a7da1f3e3fb but Domino
's PR already updated it to a newer commit.

@jmank88 jmank88 added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit cb194d7 Dec 3, 2024
95 of 96 checks passed
@prashantkumar1982 prashantkumar1982 deleted the chore/store-prebroadcast-errors-solana-txm branch December 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants