-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: ci-core: print logs directly #15374
Conversation
This is not quite as simple as I first thought, since we still use |
@@ -240,17 +240,10 @@ jobs: | |||
id: run-tests | |||
env: | |||
OUTPUT_FILE: ./output.txt | |||
USE_TEE: false | |||
USE_TEE: ${{ matrix.type.printResults }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USE_TEE
is actually not supported anymore. However, it will use tee
if $DEBUG
is true
.
So we can set debug to true when printResults is true, and it's not a scheduled event:
USE_TEE: ${{ matrix.type.printResults }} | |
DEBUG: ${{ matrix.type.printResults == 'true' && github.event_name != 'schedule' }} |
Could also use the filtered test results when it is a scheduled run, as that uses JSON.
- name: Print Filtered Test Results
if: ${{ failure() && needs.filter.outputs.should-run-ci-core == 'true' && steps.run-tests.conclusion == 'failure' && github.event_name == 'schedule' }}
run: |
if [[ "${{ matrix.type.printResults }}" == "true" ]]; then
cat output.txt | gotestloghelper -ci
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should try to simplify this overall. Our intention in this case is to run plain go test without a bunch of options, and in principle we shouldn't have to un-configure things to achieve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, the pipeline itself and these scripts are too complex.
I'm heads down on the test binary hashing solution, which will likely blow up this pipeline so not sure if it's worth investing a lot of time to simplify the existing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikburt maybe this is good enough for now? #15395; we do have the logs we wanted: https://github.com/smartcontractkit/chainlink/actions/runs/12012195713/job/33482885604?pr=15395
Closing in favor of #15395 |
This indirect log printing is no longer necessary since we have limited standard logs again.