New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-4329 modify setChainRateLimiterConfig file for setting multiple rate limits #15386

Merged

RensR merged 39 commits into develop from fix/updateRatLimitConfig

Dec 10, 2024

Collaborator

jhweintraub commented Nov 22, 2024

Update the setChainRateLimitConfig() function to now accept an array of configs to make front-end management of the token pool easier.


          modify setChainRateLimiterConfig file for setting multiple rate limits

6c54396

jhweintraub requested a review from a team as a code owner

November 22, 2024 14:56


          Merge 6c54396 into 6afc0d2

9e6e783

Contributor

github-actions bot commented Nov 22, 2024 •

edited

Loading

Static analysis results are available

Hey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

jhweintraub changed the title ~~modify setChainRateLimiterConfig file for setting multiple rate limits~~ CCIP-4329 modify setChainRateLimiterConfig file for setting multiple rate limits

app-token-issuer-infra-releng bot added 2 commits

November 22, 2024 15:02


          Update gethwrappers

c6b2c10


          [Bot] Update changeset file with jira issues

2c101e1

Contributor

github-actions bot commented Nov 22, 2024 •

edited

Loading

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/smooth-cycles-draw.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

jhweintraub added 5 commits

November 22, 2024 10:18


          snapshot fix

454552e


          Merge branch 'develop' into fix/updateRatLimitConfig

d1e6d6e


          fix wrappers after merge

b65ddca


          fix test that was broken in merge

ace4de3


          fix liquidityManager snapshot which is affected by token pool changes

9088cfa

Contributor

github-actions bot commented Nov 25, 2024 •

edited

Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

RensR reviewed

View reviewed changes

contracts/src/v0.8/ccip/pools/TokenPool.sol Outdated Show resolved Hide resolved


          fix broken integration tests from removing critical setup function

687746d

jhweintraub requested review from a team as code owners

November 25, 2024 16:41

jhweintraub requested review from winder, rstout, asoliman92, makramkd, dimkouv, mateusz-sekara and 0xAustinWang

November 25, 2024 16:41

RensR reviewed

View reviewed changes

contracts/src/v0.8/ccip/test/pools/TokenPool/TokenPool.setChainRateLimiterConfigs.t.sol Show resolved Hide resolved

RensR reviewed

View reviewed changes

contracts/src/v0.8/ccip/pools/TokenPool.sol Show resolved Hide resolved

RensR reviewed

View reviewed changes

contracts/src/v0.8/ccip/test/pools/TokenPool/TokenPool.setChainRateLimiterConfigs.t.sol Show resolved Hide resolved

jhweintraub added 2 commits

November 26, 2024 09:50


          Merge branch 'develop' into fix/updateRatLimitConfig

d950f38


          add array length check for setChainRateLimitConfigs

d212e5c


          snapshot update

71f54b0

Contributor

github-actions bot commented Dec 5, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.


          Delete contracts/.changeset/orange-buckets-live.md

0c25f46

Contributor

github-actions bot commented Dec 5, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

jhweintraub requested review from a team as code owners

December 6, 2024 15:26

jhweintraub requested a review from EasterTheBunny

December 6, 2024 15:26

Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

jhweintraub force-pushed the fix/updateRatLimitConfig branch from 25f0edb to 0c25f46 Compare

December 6, 2024 15:29


          Merge branch 'develop' into fix/updateRatLimitConfig

b12d8b1

Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

1 similar comment

Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.


          attempt fix changeset

56561e5

Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.


          attempt changeset fix with update pnpm package

ac800ac

Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

jhweintraub added 3 commits

December 9, 2024 09:56


          Merge branch 'develop' into fix/updateRatLimitConfig

1ef59ef


          re-add function that was removed early in PR to prevent any required …

5886d85

…tooling changes


          update liquidityManager snapshot because of changes to token pools

50ff55b

0xsuryansh approved these changes

View reviewed changes

RensR approved these changes

View reviewed changes

RensR added this pull request to the merge queue

Merged via the queue into develop with commit 62c2376

204 checks passed

RensR deleted the fix/updateRatLimitConfig branch

December 10, 2024 10:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

0xsuryansh 0xsuryansh approved these changes

RensR RensR approved these changes

winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny was automatically assigned from smartcontractkit/foundations

Labels

None yet