deployment/ccip/changeset: add transfer/accept ownership changeset #15409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
use these changesets in other tests and axe duplicate code
makramkd
changed the title
makramkd
changed the title
AnieeG
reviewed
Nov 26, 2024
| ) | ||
|
|
||
| func Test_NewAcceptOwnershipChangeset(t *testing.T) { | ||
| e := NewMemoryEnvironmentWithJobs(t, logger.TestLogger(t), 2, 4) |
There was a problem hiding this comment.
I think we can just use a generic test for this if you are moving to common changeset
There was a problem hiding this comment.
I kept the CCIP test but moved the changeset to common
AnieeG
previously approved these changes
Nov 27, 2024
connorwstein
previously approved these changes
Nov 27, 2024
the AddChainInbound test is consistently failing with a "message too costly" error in exec; increasing the relative boost per wait hour causes exec to significantly boost the paid fee so we can execute the message.
AnieeG
approved these changes
Nov 27, 2024
| return metaDataPerChain, nil | ||
| } | ||
|
|
||
| // Given batches of operations, we build the metadata and timelock addresses of those opartions |
There was a problem hiding this comment.
Suggested change
| // Given batches of operations, we build the metadata and timelock addresses of those opartions | |
| // Given batches of operations, we build the metadata and timelock addresses of those operations |
0xnogo
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://smartcontract-it.atlassian.net/browse/CCIP-4396
This PR adds:
This PR also adds a test for the above changesets, and deletes some TODO'd code that does the same stuff as the above and updates the tests to use the changesets instead.