Fee boosting improvements #15418
Merged
Fee boosting improvements #15418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
0xnogo
requested review from
jmank88,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
makramkd
reviewed
Nov 29, 2024
Comment on lines
36
to
38
| e, _, _ := testsetups.NewLocalDevEnvironment(t, logger.TestLogger(t), linkPrice, wethPrice, &changeset.TestConfigs{ | ||
| IsFeeBoosting: true, | ||
| }) |
There was a problem hiding this comment.
Can we see if this test can be run using the sim chain? It would greatly increase the speed of the test
makramkd
previously approved these changes
Nov 29, 2024
makramkd
reviewed
Nov 29, 2024
makramkd
approved these changes
Nov 29, 2024
asoliman92
reviewed
Nov 29, 2024
asoliman92
reviewed
Nov 29, 2024
| ), | ||
| ) | ||
|
|
||
| return execCost.Cmp(fee) > 0 |
There was a problem hiding this comment.
Nit
Suggested change
| return execCost.Cmp(fee) > 0 | |
| return willBoost |
asoliman92
approved these changes
Nov 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.