Add extra check for decimal math #15419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
RayXpub
reviewed
Nov 27, 2024
| /// @dev This function assumes the inputs don't overflow and does no checks to avoid this. For any normal inputs, this | ||
| /// should not be a problem. The only way to overflow is when the given arguments cannot be represented in the uint256 | ||
| /// type, which means the inputs are invalid. | ||
| /// @dev This function protects against overflows. If there is a transaction that hits the overflow check, it is |
There was a problem hiding this comment.
Suggested change
| /// @dev This function protects against overflows. If there is a transaction that hits the overflow check, it is | |
| /// @dev This function protects against overflows. If there is a transaction that hits the overflow check, it is |
RayXpub
previously approved these changes
Nov 27, 2024
0xsuryansh
reviewed
Nov 28, 2024
| // would overflow. | ||
| if ( | ||
| i_tokenDecimals - remoteDecimals > 77 | ||
| || remoteAmount > type(uint256).max / (10 ** (i_tokenDecimals - remoteDecimals)) |
There was a problem hiding this comment.
We do these calculations multiple times
Can we compute then once and then use it further
Example
decimalsDifference = remoteDecimals - i_tokenDecimals;
factor = 10 ** decimalsDifference;
mateusz-sekara
previously approved these changes
Nov 28, 2024
makramkd
previously approved these changes
Nov 28, 2024
RensR
dismissed stale reviews from makramkd, mateusz-sekara, and RayXpub
via
5750d81
RensR
force-pushed
the
improve-pool-tests
branch
from
5750d81 to
b2ec9b8
Compare
0xsuryansh
approved these changes
Nov 28, 2024
RayXpub
approved these changes
Nov 28, 2024
makramkd
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra checks for decimal math in pools
Clean up USDC tests