[CAPPL-316] implement FetchFunc #15424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agparadiso
force-pushed
the
CAPPL-316_FetchFunc
branch
from
930f750 to
fc97fac
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
agparadiso
force-pushed
the
CAPPL-316_FetchFunc
branch
from
fc97fac to
968a8a1
Compare
| ctx context.Context, | ||
| lggr logger.Logger, | ||
| och *webapi.OutgoingConnectorHandler, | ||
| workflowID, workflowExecutionID string, |
There was a problem hiding this comment.
You won't have an execution ID when using the syncer, so the ID should be generated from something else -- I think the secretsURL should be enough here. You should pull this directly from the call being made, not from the closure created by the constructor.
You won't have a risk of multiple requests being made so I think you can also remove the random UUID being added as well
There was a problem hiding this comment.
got it, will modify it now 🙇🏼
| ghcapabilities "github.com/smartcontractkit/chainlink/v2/core/services/gateway/handlers/capabilities" | ||
| ) | ||
|
|
||
| func NewFetcherFunc( |
There was a problem hiding this comment.
@agparadiso Does this need to be plugged in somewhere?
There was a problem hiding this comment.
IIUC this will be passed to the NewWorkflowRegistry method, but this is not used anywhere yet.
MStreet3
approved these changes
Nov 27, 2024
cedric-cordenier
approved these changes
Nov 27, 2024
justinkaseman
added a commit
that referenced
this pull request
Nov 27, 2024
This reverts commit 935612e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr implements the FetchFunc that the NewWorkflowRegistry method will use in order to fetch the secrets using the gateway.
CAPPL-316
Requires
Supports