integration-tests/smoke/ccip: increase batch size #15444
Merged
+312
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
requested review from
Atrax1,
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
jmank88
previously approved these changes
Dec 2, 2024
This reverts commit 449a77d.
dimkouv
reviewed
Dec 6, 2024
| common.LeftPadBytes(state.Chains[destChainSelector].Receiver.Address().Bytes(), 32), | ||
| ) | ||
| var err error | ||
| for i := 0; i < 3; i++ { |
There was a problem hiding this comment.
better define 3 in a const.
dimkouv
previously approved these changes
Dec 6, 2024
asoliman92
reviewed
Dec 6, 2024
| @@ -66,7 +66,7 @@ func evmChain(t *testing.T, numUsers int) EVMChain { | |||
| owner, err := bind.NewKeyedTransactorWithChainID(key, big.NewInt(1337)) | |||
| require.NoError(t, err) | |||
| genesis := types.GenesisAlloc{ | |||
| owner.From: {Balance: big.NewInt(0).Mul(big.NewInt(700000), big.NewInt(params.Ether))}} | |||
| owner.From: {Balance: assets.Ether(100_000).ToInt()}} | |||
There was a problem hiding this comment.
Why lowering the amount?
There was a problem hiding this comment.
Thats also why I added the underscores
asoliman92
previously approved these changes
Dec 6, 2024
dimkouv
approved these changes
Dec 6, 2024
asoliman92
approved these changes
Dec 6, 2024
mateusz-sekara
approved these changes
Dec 6, 2024
b-gopalswami
approved these changes
Dec 6, 2024
AnieeG
approved these changes
Dec 6, 2024
kalverra
approved these changes
Dec 6, 2024
jhweintraub
pushed a commit
that referenced
this pull request
Dec 6, 2024
* integration-tests/smoke/ccip: increase batch size * bump balance of sender * bump cl-ccip to main * deployment/ccip/changeset: conform to ChangeSet iface * Revert "deployment/ccip/changeset: conform to ChangeSet iface" This reverts commit 449a77d. * changes * split into separate tests * fix lint * rm comment * const * bump to a million
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://smartcontract-it.atlassian.net/browse/CCIP-4398
Test_tests instead oft.Runfor more robustness and isolationUsersset in theEnvironmentwhich should already be fundedRequires: