Add generic codec for CCIP plugin #15454
Conversation
… need to handle big int pointer
AER Report: CI Coreaer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Flakeguard Deployment Project , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/codec, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm, ubuntu-latest) , Flakeguard Root Project / Report , SonarQube Scan , Flakey Test Detection 1. File is not
|
| "github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/types" | ||
| ) | ||
|
|
||
| const commitReportABI = `[{"components":[{"name":"chainSel","type":"uint64","internalType":"uint64"},{"name":"onRampAddress","type":"bytes","internalType":"bytes"},{"name":"seqNumsRange","type":"uint64[2]","internalType":"uint64[2]"},{"name":"merkleRoot","type":"bytes32","internalType":"bytes32"}],"name":"merkleRoots","type":"tuple[]","internalType":"struct MerkleRootChain[]"},{"components":[{"components":[{"name":"tokenID","type":"string","internalType":"string"},{"name":"price","type":"uint256","internalType":"uint256"}],"name":"tokenPriceUpdates","type":"tuple[]","internalType":"struct TokenPrice[]"},{"components":[{"name":"chainSel","type":"uint64","internalType":"uint64"},{"name":"gasPrice","type":"uint256","internalType":"uint256"}],"name":"gasPriceUpdates","type":"tuple[]","internalType":"struct GasPriceChain[]"}],"name":"priceUpdates","type":"tuple","internalType":"struct PriceUpdates"},{"components":[{"name":"r","type":"bytes32","internalType":"bytes32"},{"name":"s","type":"bytes32","internalType":"bytes32"}],"name":"rmnSignatures","type":"tuple[]"}]` |
There was a problem hiding this comment.
Would be generated from the contracts eventually?
There was a problem hiding this comment.
Yes, that would be ideal. The existing generated ABI seems match with the format from generated MerkleRoot, not with the original report format. See discussion from slack thread
| cd, err := codec.NewCodec(commitCodecConfig) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
https://smartcontract-it.atlassian.net/browse/NONEVM-935
This is part of the change for supporting solana plugin codec. The plugin component will use generic codec for encode and decode commit and exec report. This PR adds a new commitReportCodec and execReportCodec using the evm codec. Once Solana codec is fully implemented, we will add the solana implementation under ccipsolana