CCIP-4174 Add token address to TokenHandlingError #15458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
force-pushed
the
CCIP-4174-impossible-to-determine-what-token-failed-if-multiple-are-transferred
branch
from
f8c8a28 to
434d99b
Compare
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
RayXpub
reviewed
Nov 29, 2024
RayXpub
reviewed
Nov 29, 2024
contracts/src/v0.8/ccip/test/offRamp/OffRamp/OffRamp.releaseOrMintSingleToken.t.sol
Outdated
Show resolved
Hide resolved
RayXpub
reviewed
Nov 29, 2024
contracts/src/v0.8/ccip/test/offRamp/OffRamp/OffRamp.releaseOrMintTokens.t.sol
Outdated
Show resolved
Hide resolved
RayXpub
approved these changes
Nov 29, 2024
0xsuryansh
approved these changes
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RensR
deleted the
CCIP-4174-impossible-to-determine-what-token-failed-if-multiple-are-transferred
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the comment above TokenPool