Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1862] remove logstream #15465

Merged
merged 28 commits into from
Dec 12, 2024
Merged

[TT-1862] remove logstream #15465

merged 28 commits into from
Dec 12, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Nov 29, 2024

Here we remove logstream since we cannot stream logs to Loki anyway anymore (and in the future we will use a different solution for doing it). Now we will just dump all Docker container logs to files using Docker API, and then upload these files as artifacts, if the test failed.

This vastly simplifies our code :-)

Copy link
Contributor

github-actions bot commented Dec 2, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@Tofel Tofel marked this pull request as ready for review December 6, 2024 13:26
@Tofel Tofel requested review from a team as code owners December 6, 2024 13:26
@Tofel Tofel force-pushed the tt_1862_remove_logstream branch from 410e522 to 726a0b3 Compare December 9, 2024 10:10
mateusz-sekara
mateusz-sekara previously approved these changes Dec 10, 2024
kalverra
kalverra previously approved these changes Dec 10, 2024
@Tofel Tofel added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 10, 2024
@Tofel Tofel dismissed stale reviews from kalverra and mateusz-sekara via d63ecb5 December 10, 2024 17:44
@Tofel Tofel enabled auto-merge December 10, 2024 18:15
kalverra
kalverra previously approved these changes Dec 10, 2024
b-gopalswami
b-gopalswami previously approved these changes Dec 10, 2024
@Tofel Tofel added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@Tofel Tofel dismissed stale reviews from b-gopalswami and kalverra via f087d9e December 11, 2024 08:36
@skudasov skudasov self-requested a review December 11, 2024 09:30
@Tofel Tofel enabled auto-merge December 11, 2024 09:57
@Tofel Tofel added this pull request to the merge queue Dec 12, 2024
Merged via the queue into develop with commit 8804925 Dec 12, 2024
190 checks passed
@Tofel Tofel deleted the tt_1862_remove_logstream branch December 12, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants