Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): add link token transfer changesets #15469

Closed
wants to merge 1 commit into from

Conversation

graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Nov 30, 2024

Added a new changeset in shared package which transfer the link token.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1314

@graham-chainlink graham-chainlink requested review from a team as code owners November 30, 2024 06:28
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from cf075dc to bc7d09e Compare December 2, 2024 01:45
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from bc7d09e to fe15cc5 Compare December 3, 2024 13:09
Copy link
Contributor

github-actions bot commented Dec 3, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/common/changeset, ubuntu-latest) , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan

1. Undefined function LoadLinkTokenState:

[Run tests] [2024-12-09T12:30:50.0739112Z] [common/changeset/transfer_link_token.go:57:21: undefined: LoadLinkTokenState]

Source of Error:
# github.com/smartcontractkit/chainlink/deployment/common/changeset
common/changeset/transfer_link_token.go:57:21: undefined: LoadLinkTokenState

Why: The error indicates that the function LoadLinkTokenState is being called in the file transfer_link_token.go but it is not defined or imported in the scope of this file.

Suggested fix: Ensure that LoadLinkTokenState is defined and properly imported in transfer_link_token.go. If it is defined in another package, make sure to import that package correctly. If it is missing, define the function in the appropriate location.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch 2 times, most recently from 4ee2d85 to 3d457d3 Compare December 4, 2024 06:55
@graham-chainlink graham-chainlink changed the title feat(deployment): add link token batch transfer changeset feat(deployment): add link token transfer changeset Dec 4, 2024
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from 3d457d3 to 68c8f21 Compare December 4, 2024 12:11
@graham-chainlink graham-chainlink changed the title feat(deployment): add link token transfer changeset feat(deployment): add link token transfer changesets Dec 4, 2024
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch 2 times, most recently from bafa0b5 to fb4e1e0 Compare December 4, 2024 12:56
RodrigoAD
RodrigoAD previously approved these changes Dec 4, 2024
return nil
}

// TransferLinkToken transfers link token to the to address on the chain identified by the chainSelector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems more like a QA function not really a configuration change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, we were planning to use this as a test and example for MCMS. Let me check with @RodrigoAD , see what he thinks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems more like a QA function not really a configuration change?

Configuration is hard to define, in our case, any operation that is required to operate a protocol should be a changeset, as we need all the extra capabilities it provides, e.g. wrap the tx into a MCMS proposal. This operation falls in that category. Besides that, LINK is a simple contract that everyone understands, and will serve as a reference on how to implement changeset operations and proposals

@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from fb4e1e0 to b08abf3 Compare December 5, 2024 14:55
@graham-chainlink graham-chainlink requested a review from a team as a code owner December 5, 2024 14:55
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from b08abf3 to 6643db8 Compare December 6, 2024 05:08
Added a new changesets in shared package which transfer the link token

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1314
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1314/link-token-transfer branch from 6643db8 to 8a7e714 Compare December 9, 2024 12:28
@graham-chainlink graham-chainlink deleted the ggoh/DPA-1314/link-token-transfer branch December 10, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants