-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployment): add link token transfer changesets #15469
Conversation
cf075dc
to
bc7d09e
Compare
bc7d09e
to
fe15cc5
Compare
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/common/changeset, ubuntu-latest) , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan 1. Undefined function
|
4ee2d85
to
3d457d3
Compare
3d457d3
to
68c8f21
Compare
bafa0b5
to
fb4e1e0
Compare
return nil | ||
} | ||
|
||
// TransferLinkToken transfers link token to the to address on the chain identified by the chainSelector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems more like a QA function not really a configuration change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, we were planning to use this as a test and example for MCMS. Let me check with @RodrigoAD , see what he thinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems more like a QA function not really a configuration change?
Configuration is hard to define, in our case, any operation that is required to operate a protocol should be a changeset, as we need all the extra capabilities it provides, e.g. wrap the tx into a MCMS proposal. This operation falls in that category. Besides that, LINK is a simple contract that everyone understands, and will serve as a reference on how to implement changeset operations and proposals
fb4e1e0
to
b08abf3
Compare
b08abf3
to
6643db8
Compare
Added a new changesets in shared package which transfer the link token JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1314
6643db8
to
8a7e714
Compare
Added a new changeset in shared package which transfer the link token.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1314