Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPA-1357]: fix: include OCR secrets as part of deployment.Environment #15470

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Dec 2, 2024

There are many cases where a changeset requires access to the OCR secrets and because it is not accessible via deployment.Environment, users are left no choice but to pass secrets as config in a changesets. By plumbing OCR secrets in deployment.Environment, user will no longer need to do the workaround.

Update code to use OCR secrets from the env instead of from requests/config

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1357

Used by: https://github.com/smartcontractkit/chainlink-deployments/pull/253

@graham-chainlink graham-chainlink requested review from a team as code owners December 2, 2024 06:55
Copy link
Contributor

github-actions bot commented Dec 2, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

cgruber
cgruber previously approved these changes Dec 4, 2024
deployment/environment.go Show resolved Hide resolved
@cgruber
Copy link
Collaborator

cgruber commented Dec 4, 2024

Some solana things seem broken at this commit-point. I would rebase against latest, and see if the tests pass. It seems entirely unrelated to this PR.

cgruber
cgruber previously approved these changes Dec 5, 2024
Copy link
Collaborator

@cgruber cgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll have to do the thing in CLD once this is done, of course. Once this is merged, changesets that use env.OCRSecrets will break until CLD primes the environments with them.

@cgruber
Copy link
Collaborator

cgruber commented Dec 5, 2024

This is great, but you'll have to do the instructions in this comment since you touched things in /core. It requires a different sort of "changeset" (a changelog notes system we use in core).

@graham-chainlink
Copy link
Collaborator Author

graham-chainlink commented Dec 6, 2024

smartcontractkit/chainlink-deployments#253

Yes, this is the CLD PR that will consume this PR. I plan to merge that PR together with this once this is merged.

This is great, but you'll have to do the instructions in #15470 (comment) since you touched things in /core. It requires a different sort of "changeset" (a changelog notes system we use in core).

Cool, i have merge conflicts too , so will address them together.

@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1357/plumb-ocr-secrets branch from 9486fff to 2ebca67 Compare December 6, 2024 04:10
@graham-chainlink graham-chainlink requested a review from a team as a code owner December 6, 2024 04:10
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1357/plumb-ocr-secrets branch from 2ebca67 to bbe28fb Compare December 6, 2024 04:21
@graham-chainlink graham-chainlink requested a review from a team as a code owner December 6, 2024 04:21
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1357/plumb-ocr-secrets branch from bbe28fb to de01428 Compare December 6, 2024 04:26
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1357/plumb-ocr-secrets branch from de01428 to 260c626 Compare December 6, 2024 04:42
cgruber
cgruber previously approved these changes Dec 6, 2024
There are many cases where a changeset requires access to the OCR secrets and because it is not accessible via `deployment.Environment`, users are left no choice but to pass secrets as config in a changesets.
By plumbing OCR secrets in `deployment.Environment`, user will no longer need to do the workaround.

Update code to use OCR secrets from the env instead of from requests.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1357
@graham-chainlink graham-chainlink added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@graham-chainlink graham-chainlink added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@graham-chainlink graham-chainlink added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit 54938d4 Dec 9, 2024
187 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/DPA-1357/plumb-ocr-secrets branch December 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants