-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPA-1357]: fix: include OCR secrets as part of deployment.Environment #15470
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Some solana things seem broken at this commit-point. I would rebase against latest, and see if the tests pass. It seems entirely unrelated to this PR. |
c0d4b61
to
cc6d90f
Compare
52d99f7
to
9486fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We'll have to do the thing in CLD once this is done, of course. Once this is merged, changesets that use env.OCRSecrets will break until CLD primes the environments with them.
This is great, but you'll have to do the instructions in this comment since you touched things in /core. It requires a different sort of "changeset" (a changelog notes system we use in core). |
Yes, this is the CLD PR that will consume this PR. I plan to merge that PR together with this once this is merged.
Cool, i have merge conflicts too , so will address them together. |
9486fff
to
2ebca67
Compare
2ebca67
to
bbe28fb
Compare
bbe28fb
to
de01428
Compare
de01428
to
260c626
Compare
There are many cases where a changeset requires access to the OCR secrets and because it is not accessible via `deployment.Environment`, users are left no choice but to pass secrets as config in a changesets. By plumbing OCR secrets in `deployment.Environment`, user will no longer need to do the workaround. Update code to use OCR secrets from the env instead of from requests. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1357
260c626
to
2af3b46
Compare
There are many cases where a changeset requires access to the OCR secrets and because it is not accessible via
deployment.Environment
, users are left no choice but to pass secrets as config in a changesets. By plumbing OCR secrets indeployment.Environment
, user will no longer need to do the workaround.Update code to use OCR secrets from the env instead of from requests/config
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1357
Used by: https://github.com/smartcontractkit/chainlink-deployments/pull/253