Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccip-4473 additional users in test #15497

Merged
merged 18 commits into from
Dec 4, 2024
Merged

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Dec 3, 2024

  • Various tests need different users ( which would be different than deployer key) to initiate user specific actions. Added a set of funded users as Users []*bind.TransactOpts in DeployedEnv ( mainly used for testing) so that tests have access to a set of funded non-deployer keys.
  • Updated CCIPSendRequest accordingly so that test can set a specific sender.
  • Removed HomeChainSel , feedChainSel from generic devenv.EnvironmentConfig to make it product agnostic.
  • Updated docker tests to enable taking deployer key input from KMS if no private key is specified. It will help us running tests in testnet and triggering tests from CI without having to worry about test owner key.

connorwstein
connorwstein previously approved these changes Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@AnieeG AnieeG enabled auto-merge December 4, 2024 00:15
@AnieeG AnieeG added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 29e5b3b Dec 4, 2024
184 of 185 checks passed
@mateusz-sekara mateusz-sekara deleted the CCIP-4473-users-in-test branch December 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants