Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4476 remove legacy curse check in rmnRemote #15523

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

jhweintraub
Copy link
Collaborator

Add check for LEGACY_CURSE_SUBJECT to offRamp checks.

@jhweintraub jhweintraub requested a review from a team as a code owner December 5, 2024 15:02
@jhweintraub jhweintraub changed the title add legacy curse check to offramps remove legacy curse check to offramps Dec 5, 2024
@jhweintraub jhweintraub changed the title remove legacy curse check to offramps CCIP-4476 remove legacy curse check to offramps Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Static analysis results are available

Hey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/eighty-cycles-film.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Dec 5, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@jhweintraub jhweintraub changed the title CCIP-4476 remove legacy curse check to offramps CCIP-4476 remove legacy curse check in offramps Dec 5, 2024
@jhweintraub jhweintraub changed the title CCIP-4476 remove legacy curse check in offramps CCIP-4476 remove legacy curse check in rmnRemote Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

contract RMNRemote_global_and_legacy_curses is RMNRemoteSetup {
function test_global_and_legacy_curses_success() public {
contract RMNRemote_global_curses is RMNRemoteSetup {
function test_global_curses_success() public {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new test naming convention for anything you touch. It's best to update the entire file once you touch it to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants