-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4476 remove legacy curse check in rmnRemote #15523
base: develop
Are you sure you want to change the base?
Conversation
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
It appears that the changeset file you've added or modified in |
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
It appears that the changeset file you've added or modified in |
It appears that the changeset file you've added or modified in |
It appears that the changeset file you've added or modified in |
contract RMNRemote_global_and_legacy_curses is RMNRemoteSetup { | ||
function test_global_and_legacy_curses_success() public { | ||
contract RMNRemote_global_curses is RMNRemoteSetup { | ||
function test_global_curses_success() public { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the new test naming convention for anything you touch. It's best to update the entire file once you touch it to maintain consistency.
Add check for
LEGACY_CURSE_SUBJECT
to offRamp checks.