Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-1086 return finality violation error in health report #15548

Merged
merged 9 commits into from
Dec 13, 2024
Merged

BCFR-1086 return finality violation error in health report #15548

merged 9 commits into from
Dec 13, 2024
+39 −5

Conversation

dhaidashenko
Copy link
Collaborator

@dhaidashenko dhaidashenko commented Dec 6, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

prashantkumar1982
prashantkumar1982 reviewed Dec 6, 2024
View reviewed changes
core/services/relay/evm/chain_reader.go
@@ -178,7 +179,12 @@ func (cr *chainReader) Close() error {
func (cr *chainReader) Ready() error { return nil }

func (cr *chainReader) HealthReport() map[string]error {
return map[string]error{cr.Name(): nil}
report := map[string]error{
cr.Name(): cr.Healthy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the CR Healthy() implementation should append all reports from underlying components like ht, lp, client, etc.
But I assume for now you are only worried about making FV work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Initially, I thought HT and the Client did not support reports, but it turns out that I've checked HT's interface instead of implementation.
Added propagation of HT reports. Created aticket to also implement it for client.

@dhaidashenko
propagate headtracker's errors
0ef6201
@dhaidashenko
Merge branch 'develop' into feature/BCFR-1086-finality-violation
baae23f 
# Conflicts:
#	core/scripts/go.mod
#	core/scripts/go.sum
#	deployment/go.mod
#	deployment/go.sum
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
#	integration-tests/load/go.mod
#	integration-tests/load/go.sum
@dhaidashenko
bump chainlink-common
2a5749f
@dhaidashenko
Merge branch 'develop' into feature/BCFR-1086-finality-violation
3c77161 
# Conflicts:
#	core/scripts/go.sum
#	deployment/go.mod
#	deployment/go.sum
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
#	integration-tests/load/go.sum
@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 3c77161 (feature/BCFR-1086-finality-violation).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestLogPoller_BlockTimestamps 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller false 126.666666ms @smartcontractkit/bix-framework, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@dhaidashenko
Merge branch 'develop' into feature/BCFR-1086-finality-violation
ab8add5 
# Conflicts:
#	integration-tests/load/go.mod
@dhaidashenko dhaidashenko marked this pull request as ready for review December 12, 2024 17:16
@dhaidashenko dhaidashenko requested review from a team as code owners December 12, 2024 17:16
@reductionista reductionista added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 2ec4d6c Dec 13, 2024
170 of 171 checks passed
@reductionista reductionista deleted the feature/BCFR-1086-finality-violation branch December 13, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@reductionista reductionista reductionista approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhaidashenko @reductionista @prashantkumar1982