Zksync separate function

[yashnevatia]

Requires

Supports

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan

1. Undefined field or method Tx in ContractDeploy type: [go_core_ccip_deployment_tests]

Source of Error:

# github.com/smartcontractkit/chainlink/deployment
./helpers.go:145:41: contractDeploy.Tx undefined (type ContractDeploy[C] has no field or method Tx)

**Why**: The `ContractDeploy` type does not have a field or method named `Tx`. This could be due to a recent change in the type definition or a typo.

Suggested fix: Verify the definition of ContractDeploy and ensure that it includes the Tx field or method. If it was recently removed or renamed, update the code accordingly.

2. Missing zksolc command: [go_core_tests]

Source of Error:

/home/runner/work/chainlink/chainlink/contracts/scripts/native_solc_compile_all_ccip: line 43: zksolc: command not found

**Why**: The script `native_solc_compile_all_ccip` attempts to call `zksolc`, but the command is not found in the environment. This indicates that `zksolc` is either not installed or not available in the PATH.

Suggested fix: Ensure that zksolc is installed and available in the PATH. You may need to add an installation step for zksolc in your CI configuration.

3. Unused functions and formatting issues: [Golang Lint]

Source of Error:

core/gethwrappers/abigen.go:572:6: func `parseFuncDecl` is unused (unused)
core/gethwrappers/abigen.go:658:6: func `addZKSyncBlock` is unused (unused)
core/gethwrappers/abigen.go:687:6: func `updateTxReturnType` is unused (unused)
core/gethwrappers/abigen.go:697:6: func `updateReturnStmt` is unused (unused)
core/gethwrappers/ccip/generated/lock_release_token_pool/lock_release_token_pool.go:3712:2: unnecessary trailing newline (whitespace)
core/gethwrappers/ccip/generated/token_admin_registry/token_admin_registry.go:1543:17: unnecessary leading newline (whitespace)
core/gethwrappers/abigen.go:476:61: unnecessary leading newline (whitespace)
core/gethwrappers/abigen.go:531:98: unnecessary leading newline (whitespace)
core/gethwrappers/abigen.go:511:36: fmt.Sprintf can be replaced with string concatenation (perfsprint)
core/gethwrappers/abigen.go:586:14: fmt.Errorf can be replaced with errors.New (perfsprint)

**Why**: The linter found several issues including unused functions, unnecessary newlines, and suboptimal usage of `fmt.Sprintf` and `fmt.Errorf`.

Suggested fix: Remove or use the unused functions, correct the formatting issues by removing unnecessary newlines, and replace fmt.Sprintf with string concatenation and fmt.Errorf with errors.New where applicable.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit