[WIP] Granular MCMS optional CCIP chain contract changesets

[connorwstein]

Requires

Supports

[github-actions]

Flakeguard Summary

Ran new or updated tests between develop and 07b72d9 (CCIP-4567-granular-mcms-optional-changsets-for-chain-contracts).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestInitialAddChainAppliedTwice	66.67%	false	false	false	3	2	1	0	github.com/smartcontractkit/chainlink/deployment/ccip/changeset	false	1m58.276666666s	@smartcontractkit/ccip, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Deployment Project / Report

1. Error stopping job service:[Run tests]

Source of Error:

Run tests	2024-12-12T16:36:58.7598035Z logger.go:146: 2024-12-12T16:36:33.620Z	DPANIC	JobSpawner	job/spawner.go:175	Error stopping job service	{"version": "unset@unset", "jobID": 1, "subservice": 3, "serviceType": "*launcher.launcher", "err": "failed to close RMN home reader: has already been stopped: already stopped; failed to close RMN home reader: has already been stopped: already stopped", "errCauses": [{"error": "failed to close RMN home reader: has already been stopped: already stopped"}, {"error": "failed to close RMN home reader: has already been stopped: already stopped"}]}
Run tests	2024-12-12T16:36:58.7598568Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopService
Run tests	2024-12-12T16:36:58.7599005Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:175
Run tests	2024-12-12T16:36:58.7599487Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopAllServices
Run tests	2024-12-12T16:36:58.7599920Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:152
Run tests	2024-12-12T16:36:58.7600367Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close.func1
Run tests	2024-12-12T16:36:58.7600796Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:114
Run tests	2024-12-12T16:36:58.7601263Z github.com/smartcontractkit/chainlink-common/pkg/services.(*StateMachine).StopOnce
Run tests	2024-12-12T16:36:58.7602054Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241210192653-a9c706f99e83/pkg/services/state.go:132
Run tests	2024-12-12T16:36:58.7602533Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close
Run tests	2024-12-12T16:36:58.7602957Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:112
Run tests	2024-12-12T16:36:58.7603533Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).stop.func1
Run tests	2024-12-12T16:36:58.7604015Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:824

Why: The error occurred because the job service attempted to stop a subservice that had already been stopped, leading to a redundant stop operation.

Suggested fix: Ensure that the service stop logic checks if the service is already stopped before attempting to stop it again. This can be done by adding a condition to verify the service state before executing the stop operation.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit