Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMN tests CI reliability and one new test scenario #15677

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

dimkouv
Copy link
Contributor

@dimkouv dimkouv commented Dec 13, 2024

Pull Request Description: Improve RMN Test Reliability and Add New Test Case

Summary

This PR makes the following changes to improve test reliability and enhance test coverage for RMN:

  1. Re-enabled RMN Tests:

    • Shifted tests to use CLL-managed runners instead of GitHub shared runners.
    • This transition helps prevent flakiness and ensures a more stable testing environment.
  2. Added a New Test Case:

    • Introduced a test scenario where a chain is cursed and then uncursed, verifying expected behavior in both states.

Why These Changes?

  • The flakiness of tests on shared runners was causing unnecessary delays and reducing confidence in CI reliability.
  • Adding the cursed-to-uncursed test case strengthens coverage for edge-case scenarios, ensuring robust functionality.

Testing and Validation

  • Verified that RMN tests run reliably on the CLL-managed runners (performed 5 retries).
  • Ensured that the new test case passed under expected conditions and did not introduce regressions.

Impact

  • Improved reliability and predictability of CI pipelines.
  • Enhanced confidence in the correctness of RMN functionality.

@dimkouv dimkouv changed the title Re-enable rmn tests with larger runners RMN tests CI reliability and one new test scenario Dec 13, 2024
@dimkouv dimkouv marked this pull request as ready for review December 13, 2024 09:50
@dimkouv dimkouv requested review from a team as code owners December 13, 2024 09:50
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 6f42463 Dec 13, 2024
188 checks passed
@cedric-cordenier cedric-cordenier deleted the dk/rmn-tests-enable branch December 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants