Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp fix to chainreader error when no workflows #15678

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Dec 13, 2024

It appears that chainreader errors when getWorkflowForDon returns an empty collection as does not handle the return type (empty []byte) correctly when decoding to the passed type. This PR is a temporary workaround for that issue in the workflow registry syncer initial load.

@ettec ettec requested review from a team as code owners December 13, 2024 10:48
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 19b122a Dec 13, 2024
169 of 170 checks passed
@cedric-cordenier cedric-cordenier deleted the wfregistry-initial-load-workwround-fix branch December 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants