Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wsrpc version upgrade #15692

Open
wants to merge 3 commits into
base: release/2.17.0-mercury-20241004
Choose a base branch
from

Conversation

JoshC2k
Copy link

@JoshC2k JoshC2k commented Dec 13, 2024

Upgrades wsrpc package version to fix a panic condition on the nodes.

@JoshC2k JoshC2k requested review from a team as code owners December 13, 2024 20:16
@JoshC2k JoshC2k requested review from EasterTheBunny and removed request for a team December 13, 2024 20:16
akuzni2
akuzni2 previously approved these changes Dec 13, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , lint , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakey Test Detection , SonarQube Scan

1. Missing grafana_org_id parameter: Re-run tests

Source of Error:
Re-run tests	2024-12-13T20:47:36.6949397Z 2024/12/13 20:47:36 Error re-running flakey tests: `grafana_org_id` is required
Re-run tests	2024-12-13T20:47:36.6967213Z ##[error]Process completed with exit code 1.

Why: The grafana_org_id parameter is missing, which is required for the re-run tests command to execute properly.

Suggested fix: Ensure that the grafana_org_id parameter is provided in the environment variables or command line arguments.

2. Go module changes detected: Ensure clean after tidy

Source of Error:
Ensure clean after tidy	2024-12-13T20:42:57.7333882Z ##[error]Process completed with exit code 1.

Why: The git diff --minimal --exit-code command detected changes in the go.sum file, indicating that the Go module dependencies are not clean after running go mod tidy.

Suggested fix: Run go mod tidy locally and commit the changes to ensure the go.sum file is up-to-date and clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants