Add changesets for self-serve token pool deployments #15877
Conversation
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (integration-tests) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , test-scripts , lint , SonarQube Scan 1. Test failure in
|
There was a problem hiding this comment.
This is a partial review.
I think we should create sep changeset for new token pool addition and Updating existing pool config otherwise it is cluttering the changeset. Also DeployTokenPoolContractsConfig name does not convey that it can be used for ExistingPoolUpdates.
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
kylesmartin
requested review from
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
kylesmartin
changed the title
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
deployment/ccip/changeset/state.go
Outdated
| } | ||
|
|
||
| // safeAppendToKey safely appends a new value to an array of values assigned to a map key. | ||
| func safeAppendToKey[K comparable, V any](mapping map[K][]V, key K, value V) map[K][]V { |
There was a problem hiding this comment.
let's export this and move to deployment/helpers.go
|
|
||
| // MakeTxOptsAndHandlerForContract creates transaction opts and a handler that either submits and confirms a transaction or outputs it as an MCMS operation, | ||
| // depending on whether or not an MCMS config is supplied. | ||
| func MakeTxOptsAndHandlerForContract( |
There was a problem hiding this comment.
Can you check existing deployer_group and see if it is similar to what you are trying to achieve here?
There was a problem hiding this comment.
Had to modify the deployer group a bit: 92ce147
It didn't work with the deployer key when given transactions that depend on prior transactions causing a state change (i.e. acceptAdmin depends on proposeAdmin)
| ) | ||
|
|
||
| // getAllTokenPoolsWithSymbol returns a list of all token pools tied to the given token symbol. | ||
| func GetAllTokenPoolsWithSymbol( |
There was a problem hiding this comment.
let's make these methods unexported. It's better to let user access the changesets only
| if tokenConfig.TokenPool != c.PoolAddress && !(weCanBeAdmin || weAreAdmin) { | ||
| return fmt.Errorf("address %s is unable to be the admin of %s on %s", fromAddress, tokenSymbol, chain.String()) | ||
| } |
There was a problem hiding this comment.
Let's divide these two with more explicit error message for each case
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
https://smartcontract-it.atlassian.net/browse/CCIP-4508