-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Android project should be updated from AGP 7.4.2 #1883
Comments
Attaching SDL_Issue_1883.patch GIT Patch that I believe to resolve the AGP update recommended issue which also includes a resolution of the Deprecated attribute in AndroidManifest.xml issue. Most of the changes were do by the AGP Upgrade Assistant tool. However it would fail to load the project after the upgrade with this exception:
Update of the There are some failing tests but all of those had been failing for me also before the AGP update. |
Description
Warnings
AGP update recommended
There is this new Android Gradle Plugin (AGP) warning present since the recent upgrade to support Android SDK 34 (#1856, #1880).
Deprecated attribute in AndroidManifest.xml
And there's also one older yet related warning thrown by the manifest processing task.
Impact
Users of the
sdl_android
module who link the module source code are affected by the deprecated attribute in AndroidManifest.xml warning and because of that they cannot upgrade their project's AGP to 8+ versions without any custom modifications to thesdl_android
module's source code.The text was updated successfully, but these errors were encountered: