-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gradle version 8.2.2 #1886
Open
JulianKast
wants to merge
19
commits into
develop
Choose a base branch
from
bugfix/issue_1883_final_gradle_update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mission in unit test, update unit test imports
…uterService for test to work.
… if device is not an emulator, New emulator actually works, so to prevent incompatibility with older emulators only check on actual devices
…ities, only doing certain checks on API levels less then 30 for WiFiSocketFactoryTest
5 tasks
JulianKast
changed the title
Final Update to gradle version 8.2.2
Update to gradle version 8.2.2
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1883
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
Unit test were updated to work with API level 34 and new gradle version
Core Tests
Tested connecting Hello_SDL app to Sync 3
Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3
Summary
This PR updates gradle version to 8.2.2 to work with API level 34, as well as updates Unit test and ci checks. I also updated som imports for unit testing.
android.yml
:Runs-on
- changed frommacOS-latest
tomacos-13
.macOS-latest
uses version 12 currently, version 13 gets one more core to work with which is helpful to run the new android emulator. They also have a beta of version 14 but only for m1 chips. So to prevent the possibility of macOS-latest of one day pointing at an m1 image, this will give us more longevity and help our checks run smoother on a more demanding android emulator.arch:
- arch defaults tox86
, there are no android emulators above api level 30 that are just x86, so specifyingx86_64
is now a requirement for them to work.AudioStreamManagerTest
:We had test failing randomly when broadcast receiver were registered through some test specifying that the exported flag needed to be set, I discovered that some test in
AudioStreamManagerTest
were overwriting theBuild.VERSION.SDK_INT
to a lower api level for all test ran after, causing the exported flag to not get set.Upon fixing this we had other issues with test for the
IntegrationValidator
, I had to addTestSdlReceiver
to pass checks for the BroadcastRecevier.WiFiSocketFactoryTest
:Some test were failing due to the fact that starting in API level 30 we can no longer use reflection to fake NetworkCapabilities. I added an api level check to bypass them. There is no good way to mock them as the class is final, I tried looking into
mockito inline
andRoboelectric
but could not use them as they are unavailable inandroidTestImplementation
. There isdexmaker-mockito-inline
that could be a possibility, but that would change howmockito
is imported into the project and could affect other test.MultiplexBluetoothTransportTest
:testStateTransitions
had to be modified due to the new emulator actually starting theMultiplexBluetoothTransport
, so to prevent incompatibility with older emulators I modified it to only check on actual devicesOther unit test issues:
I had to add permissions to the manifest for our unit test as well as the queries section for the router service that is required in newer android versions
CLA