Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tuya] Add support for IR controller #501

Merged
merged 16 commits into from
Jul 23, 2023
Merged

[tuya] Add support for IR controller #501

merged 16 commits into from
Jul 23, 2023

Conversation

d51x
Copy link
Contributor

@d51x d51x commented Jul 6, 2023

No description provided.

d51x added 7 commits July 6, 2023 17:55
@d51x
[tuya] IR Controller: changed the name of the parameters
bd8de55 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: added support code in NEC-format for receiving …
84a9ac4 
…command

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: refactor code, add one ir-code channel with opt…
0c3d2d1 
…ions, remove other ir-channels

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: refactor code, add one ir-code channel with opt…
eeb2cb0 
…ions, remove other ir-channels

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: refactor code, add one ir-code channel with opt…
81419c0 
…ions, remove other ir-channels

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: refactor code, add one ir-code channel with opt…
4711f63 
…ions, remove other ir-channels,

added continuous learning mode

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: update docs
ff4b370 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x d51x requested a review from J-N-K as a code owner July 6, 2023 15:17
J-N-K
J-N-K requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In general looks good to me. My comments are mostly regarding code style. And please properly sign-off your commits (i.e. with your full name).

bundles/org.smarthomej.binding.tuya/README.md Outdated Show resolved Hide resolved
bundles/org.smarthomej.binding.tuya/README.md

Channel can receive learning key (autodetect format and put autodetected code in channel).

To start learning codes add new channel with Type String and DP = 1 and Range with `send_ir,study,study_exit,study_key`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that automatically added by discovery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be
as i know, there are two types of ir controllers - old version (works via dp201) and new version (works via dp1,2,3,4,7,10,13)
How automaticaly detects it, I don't know

and new version can work in two modes - DIY (now I can convert base64 tuya key code to nec format) and Tuya Library Mode, where key code consists from head and other data

...nding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/handler/TuyaDeviceHandler.java Outdated Show resolved Hide resolved
...nding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/handler/TuyaDeviceHandler.java Outdated Show resolved Hide resolved
...nding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/handler/TuyaDeviceHandler.java Outdated Show resolved Hide resolved
...smarthomej.binding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/util/IrUtils.java Outdated Show resolved Hide resolved
...smarthomej.binding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/util/IrUtils.java Outdated Show resolved Hide resolved
...smarthomej.binding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/util/IrUtils.java Outdated Show resolved Hide resolved
...smarthomej.binding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/util/IrUtils.java Outdated Show resolved Hide resolved
bundles/org.smarthomej.binding.tuya/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
d51x added 9 commits July 10, 2023 17:28
@d51x
[tuya] IR Controller: fix code style
781e1b5 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: fix code style
40aa177 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: fix code style & possible check for NPE
077f138 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: fix code style & possible check for NPE
06097e2 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
Merge remote-tracking branch 'd51x/4.0/tuya-ir-controller' into 4.0/t…
abca4e9 
…uya-ir-controller

# Conflicts:
#	bundles/org.smarthomej.binding.tuya/src/main/java/org/smarthomej/binding/tuya/internal/util/IrUtils.java
@d51x
[tuya] IR Controller: fix continuous learning key code
21ff55c 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[tuya] IR Controller: fix possible NPE
6c1fe69 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
fix code format after spotless check
3a14657
@d51x
fix code format after spotless check
0e887ba 
Signed-off-by: Dmitry Pyatykh <dimonich110@gmail.com>
J-N-K
J-N-K approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit ea79085 into smarthomej:4.0.x Jul 23, 2023
1 check passed
@J-N-K J-N-K added the enhancement New feature or request label Jul 23, 2023
@J-N-K J-N-K added this to the 3.2.17 milestone Jul 23, 2023
@J-N-K J-N-K changed the title 4.0/tuya ir controller [tuya] Add support for IR controller Jul 23, 2023
@J-N-K J-N-K modified the milestones: 3.2.17, 3.2.18 Jul 23, 2023
J-N-K added a commit to J-N-K/addons that referenced this pull request Jul 23, 2023
@J-N-K
[tuya] Add support for IR controller (smarthomej#501)
ad11de0 
Add support for IR controller

Signed-off-by: Dmitry Pyatykh <dimonich110@gmail.com>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.2.18
Development

Successfully merging this pull request may close these issues.
2 participants
@d51x @J-N-K