[transform.math] Fix missing unit when result is 0 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
clinique
changed the title
J-N-K
reviewed
Jul 24, 2023
Comment on lines
44
to
51
| try { | ||
| source = new QuantityType<>(sourceString); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.warn("Input value '{}' could not be converted to a valid number", sourceString); | ||
| throw new TransformationException("Math Transformation can only be used with numeric inputs"); | ||
| } | ||
| QuantityType<?> value; | ||
| String evaluated = sourceString; | ||
| try { | ||
| value = new QuantityType<>(valueString); | ||
| source = new QuantityType<>(evaluated); | ||
| evaluated = valueString; | ||
| value = new QuantityType<>(evaluated); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.warn("Input value '{}' could not be converted to a valid number", valueString); | ||
| logger.warn("Input value '{}' could not be converted to a valid number", evaluated); | ||
| throw new TransformationException("Math Transformation can only be used with numeric inputs"); | ||
| } |
There was a problem hiding this comment.
To avoid having two catch catching the same thing....could be avoided.
Comment on lines
58
to
54
| QuantityType<?> result = performCalculation(source, value); | ||
| return BigDecimal.ZERO.compareTo(result.toBigDecimal()) == 0 ? "0" : result.toString(); | ||
| return performCalculation(source, value).toString(); |
There was a problem hiding this comment.
I See why it works now, but I wonder why it was done like that before. Maybe to prevent a return value of 0.0000?
There was a problem hiding this comment.
Yes, I was wondering the same, reason why I wanted your advice.
Signed-off-by: clinique <gael@lhopital.org>
J-N-K
previously approved these changes
Jul 25, 2023
J-N-K
approved these changes
Jul 25, 2023
J-N-K
changed the title
J-N-K
added a commit
to J-N-K/addons
that referenced
this pull request
Jul 25, 2023
* Code modification proposal following issue smarthomej#506 Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #506