Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[javarule] Adding tags to Rule annotation #525

Merged
merged 6 commits into from
Oct 9, 2023
Merged

[javarule] Adding tags to Rule annotation #525

merged 6 commits into from
Oct 9, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 6, 2023

Adresses issue #504

@clinique
[Javarule] Updating Generic Event Trigger
3d4c9f3 
Solves issue smarthomej#523

Signed-off-by: clinique <gael@lhopital.org>
@clinique
[javarule] Adding tags to Rule annotation
68684d5 
Adresses issue smarthomej#504

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from J-N-K as a code owner October 6, 2023 08:06
@clinique
Copy link
Contributor Author

clinique commented Oct 6, 2023

@J-N-K : sorry I made this blindly, I'm unable to have a working IDE with your repo.

@clinique
Reverting modification of GenericEventTrigger
bdf5255 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Missing an import
a27c3b6 
Signed-off-by: clinique <gael@lhopital.org>
@J-N-K
Copy link
Member

J-N-K commented Oct 9, 2023

Which IDE are you using? It should be easy to import the maven project.

@clinique
Apply spotless
a7177d0 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Copy link
Contributor Author

clinique commented Oct 9, 2023

I'm using eclipse but maybe I'm importing at the wrong level in the folder tree.
I get Cannot parse lifecycle mapping metadata for maven project MavenProject: org.smarthomej.addons:org.smarthomej.addons.reactor:4.0.1-SNAPSHOT @ /home/sysadmin/openhab-main2/git/smarthomej/addons/pom.xml Cause: Unrecognised tag: 'version' (position: START_TAG seen ...</artifactId>\n <version>... @62:18)

@clinique
Correcting errors
182a81c 
Signed-off-by: clinique <gael@lhopital.org>
@J-N-K J-N-K merged commit 867e27a into smarthomej:4.0.x Oct 9, 2023
2 checks passed
@J-N-K J-N-K added this to the 4.0.1 milestone Oct 9, 2023
@J-N-K J-N-K added the enhancement New feature or request label Oct 9, 2023
@clinique clinique deleted the RuleAnnotation branch October 9, 2023 10:31
J-N-K added a commit that referenced this pull request Oct 9, 2023
@J-N-K
[javarule] Adding tags to Rule annotation (#525)
3140ab2 
* [javarule] Adding tags to Rule annotation
Adresses issue #504

Signed-off-by: clinique <gael@lhopital.org>
(cherry picked from commit 867e27a)
Signed-off-by: Jan N. Klug <github@klug.nrw>

# Conflicts:
#	bundles/org.smarthomej.automation.javarule/src/main/java/org/smarthomej/automation/javarule/internal/script/RuleProcessor.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@clinique @J-N-K