[http] Better handle invalid 401 response #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been discovered that some servers respond with a 401 without `WWW-Authenticate` header if the original request was sent with creentials. While this is a protocol violation, the user can't fix it, because it is server-side. This PR handles these edge cases more gracefully. Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
added a commit
that referenced
this pull request
Dec 27, 2023
It has been discovered that some servers respond with a 401 without `WWW-Authenticate` header if the original request was sent with creentials. While this is a protocol violation, the user can't fix it, because it is server-side. This PR handles these edge cases more gracefully. Signed-off-by: Jan N. Klug <github@klug.nrw> (cherry picked from commit a9dab3d)
J-N-K
added a commit
that referenced
this pull request
Dec 27, 2023
It has been discovered that some servers respond with a 401 without `WWW-Authenticate` header if the original request was sent with creentials. While this is a protocol violation, the user can't fix it, because it is server-side. This PR handles these edge cases more gracefully. Signed-off-by: Jan N. Klug <github@klug.nrw> (cherry picked from commit a9dab3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been discovered that some servers respond with a 401 without
WWW-Authenticateheader if the original request was sent with creentials. While this is a protocol violation, the user can't fix it, because it is server-side. This PR handles these edge cases more gracefully.