[androiddebugbridge] Broken hdmi status on Fire TV Cube #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17 issue) Signed-off-by: Tom Blum trinitus01@googlemail.com
Signed-off-by: Tom Blum trinitus01@googlemail.com
Signed-off-by: Tom Blum trinitus01@googlemail.com
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
J-N-K
reviewed
Oct 6, 2024
| LOGGER.debug("set fallback {} for {}", FallbackModes.LOGCAT, HDMI_STATE_CHANNEL); | ||
| channelFallbackMap.put(HDMI_STATE_CHANNEL, FallbackModes.LOGCAT); | ||
| return isHDMIOnWithLogcat(); | ||
| String result = runAdbShell("dumpsys", "hdmi_control", "|", "grep", "mPowerStatus"); |
There was a problem hiding this comment.
So this works for both cases we had before?
There was a problem hiding this comment.
Yes, it is much more stable than the previous way(s).
J-N-K
approved these changes
Oct 10, 2024
J-N-K
added a commit
that referenced
this pull request
Oct 10, 2024
* fixed: missing Content-Length header (BodyPublisher.ofByteArrays JDK 17 issue) Signed-off-by: Tom Blum <trinitus01@googlemail.com> Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
added a commit
that referenced
this pull request
Oct 10, 2024
* fixed: missing Content-Length header (BodyPublisher.ofByteArrays JDK 17 issue) Signed-off-by: Tom Blum <trinitus01@googlemail.com> Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: boken hdmi status on Fire TV Cube
Signed-off-by: Tom Blum trinitus01@googlemail.com