Skip to content

Commit

Permalink
fix: set default port to 8000 (Smartlook convention)
Browse files Browse the repository at this point in the history
  • Loading branch information
samialdury committed Jan 25, 2022
1 parent 4e10386 commit 59a1d35
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ FROM node:16-alpine as prod

ENV HOME=/home/node/app
ENV NODE_ENV=production
ENV PROXY_PORT=9000
ENV PROXY_PORT=8000

WORKDIR $HOME

Expand All @@ -40,7 +40,7 @@ COPY --from=build /home/node/app/package*.json ./

RUN npm ci --only=production

EXPOSE 9000
EXPOSE 8000

USER node

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ build:
up:
ifdef port
@echo "Running Docker image..."
docker run --env-file ./.env -d -p $(port):9000 --name smartlook-relay-proxy smartlook-relay-proxy
docker run --env-file ./.env -d -p $(port):8000 --name smartlook-relay-proxy smartlook-relay-proxy
else
$(error port is required. Usage: 'make up port=<number>'')
endif
4 changes: 2 additions & 2 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ services:
volumes:
- ./src:/home/node/app/src:ro
ports:
- 80:9000
- 80:8000
environment:
NODE_ENV: development
PROXY_PORT: 9000
PROXY_PORT: 8000
RELAY_PROXY_HOST: ${RELAY_PROXY_HOST}
2 changes: 1 addition & 1 deletion src/config/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const config = convict({
doc: 'Proxy port',
format: Number,
env: 'PROXY_PORT',
default: 9000,
default: 8000,
},
hosts: {
relayProxy: {
Expand Down

0 comments on commit 59a1d35

Please sign in to comment.