React Native Products Integration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanshg
reviewed
Sep 5, 2023
jumaallan
reviewed
Sep 11, 2023
android/src/main/java/com/smileidentity/react/SmileIDViewManager.kt
Outdated
Show resolved
Hide resolved
jumaallan
reviewed
Sep 25, 2023
jumaallan
reviewed
Sep 25, 2023
jumaallan
reviewed
Sep 25, 2023
JNdhlovu
changed the title
vanshg
requested changes
Oct 3, 2023
|
Can you also update the package name? |
Co-authored-by: Juma Allan <allanjuma@gmail.com>
Co-authored-by: Vansh Gandhi <me@van.sh>
JNdhlovu
force-pushed
the
feature/reactcompose
branch
from
657a0d9 to
653db4f
Compare
vanshg
reviewed
Oct 10, 2023
| if (hasKey("partnerParams")) { | ||
| val partnerParams = getMap("partnerParams") | ||
| return PartnerParams( | ||
| jobType = if (partnerParams!!.hasKey("jobType")) JobType.fromValue(partnerParams.getInt("jobType")) else null, |
Comment on lines
101
to
106
| val allowAgentMode = | ||
| if (product.hasKey("allowAgentMode")) product.getBoolean("allowAgentMode") else false | ||
| val showInstructions = | ||
| if (product.hasKey("showInstructions")) product.getBoolean("showInstructions") else true | ||
| val isProduction = | ||
| if (product.hasKey("isProduction")) product.getBoolean("isProduction") else false |
There was a problem hiding this comment.
same here, can do something like val allowAgentMode = product.getBoolean("allowAgentMode") ?: false
Co-authored-by: Vansh Gandhi <me@van.sh>
Co-authored-by: Vansh Gandhi <me@van.sh>
vanshg
reviewed
Oct 16, 2023
Comment on lines
37
to
40
| val partnerParams = product.partnerParams() | ||
| partnerParams ?: run { | ||
| IllegalArgumentException("partnerParams is required for enhanced kyc") | ||
| } |
There was a problem hiding this comment.
Suggested change
| val partnerParams = product.partnerParams() | |
| partnerParams ?: run { | |
| IllegalArgumentException("partnerParams is required for enhanced kyc") | |
| } | |
| val partnerParams = product.partnerParams() ?: run { | |
| throw IllegalArgumentException("partnerParams is required for enhanced kyc") | |
| } |
same for the below occurences
| country ?: run { | ||
| IllegalArgumentException("country is required for enhanced kyc") | ||
| } | ||
| val idType = if (product.hasKey("idType")) product.getString("idType") else null |
android/src/main/java/com/smileidentity/react/views/SmileIDBVNConsentScreen.kt
Outdated
Show resolved
Hide resolved
|
|
||
| override fun renderContent() { | ||
| product?.let {product-> | ||
| val partnerName = if (product.hasKey("partnerName")) product.getString("partnerName") else null |
| @@ -6,9 +6,9 @@ import type { | |||
| BvnConsentRequest, | |||
| DocumentVerificationRequest, | |||
| SmartSelfieRequest, | |||
| } from 'react-native-smile-id'; | |||
| } from '@smileid/react-native'; | |||
vanshg
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/8965/build-react-native-wrapper-android-v10
Summary
The PR now has the below products tested as well as in the sample app
Test Instructions
yarn example android
This will show the main screen and you can run the products as per the options
Known Issues
Enhance the sample app ui for other things like enhanced KYC and docv country selection etc will come in a follow up PR
@vanshg
I will have a follow up PR for dependancy versions etc