Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cd #9

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Feature/cd #9

merged 5 commits into from
Nov 13, 2023

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Nov 7, 2023

Summary

Modify the release workflow to create tags and releases on a release branch

Known Issues

Need to test this to see if everything is working fine

@JNdhlovu JNdhlovu requested review from vanshg and jumaallan November 7, 2023 13:43
git config user.email "${GITHUB_ACTOR}@users.noreply.github.com"
git tag -a "${tag}" -m "${message}"
git push origin "${tag}"
gh pr create --title "Merge release $new_version into main" --body "This is an automated pull request to update the version." --base main --head $new_branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (personally, I think it's clearer, but up to you):

Suggested change
gh pr create --title "Merge release $new_version into main" --body "This is an automated pull request to update the version." --base main --head $new_branch
gh pr create --title "Bump version to $new_version" --body "This is an automated pull request to update the version." --base main --head $new_branch

@JNdhlovu JNdhlovu merged commit 0156201 into main Nov 13, 2023
6 checks passed
@JNdhlovu JNdhlovu deleted the feature/cd branch November 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants