chore: Update to Smithy 1.53.0 #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Dec 19, 2024
| @@ -380,14 +380,14 @@ class SwiftSymbolProvider(private val model: Model, val swiftSettings: SwiftSett | |||
| if (shape.hasTrait<StreamingTrait>()) { | |||
| { writer -> | |||
| writer.format( | |||
| "\$N.data(\$N(\"$literal\".utf8))", | |||
| "\$N.data(\$N(base64Encoded: \"$literal\"))", | |||
There was a problem hiding this comment.
Smithy blob default values are always base64-encoded strings so the default is decoded here.
jbelkins
commented
Dec 19, 2024
| writer.writeInline(".stream(\$N(data: ", SmithyStreamsTypes.Core.BufferedStream) | ||
| ".data(using: .utf8)!, isClosed: true))" | ||
| writer.writeInline(".stream(\$N(data: \$N(", SmithyStreamsTypes.Core.BufferedStream, FoundationTypes.Data) | ||
| ".utf8), isClosed: true))" |
There was a problem hiding this comment.
A little code cleanup & converted to using Swift string's utf8 view to create data.
jbelkins
commented
Dec 19, 2024
| @@ -243,14 +243,16 @@ open class MemberShapeDecodeGenerator( | |||
| writer.addImport(FoundationTypes.Data) | |||
| return if (targetShape.hasTrait<StreamingTrait>()) { | |||
| writer.format( | |||
| " ?? \$N.data(\$N(\"$value\".utf8))", | |||
| " ?? \$N.data(\$N(base64Encoded: \$S))", | |||
There was a problem hiding this comment.
Same fixes here: decode the blob default string from base64 before using.
sichanyoo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates to Smithy 1.53.0.
Fixes a couple code-generated default values to decode Base64 blob defaults before using them.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.