Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make GH workflows pass in staging & refactor using composite actions #886

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Dec 17, 2024

Issue #

1934

Description of changes

  • Refactor workflows to re-use composite actions instead of having lots of duplicate steps.
  • Adjusts CI workflow to make it work in staging repo as well.
  • When the CI workflow runs in public smithy-swift repo and there is a corresponding branch in public aws-sdk-swift repo, it fetches that corresponding branch of public aws-sdk-swift to run tests.
  • When the CI workflow runs in private smithy-swift repo and there is a corresponding branch in private aws-sdk-swift repo, it fetches that corresponding branch of private aws-sdk-swift to run tests.
  • In both public and private situation, if there's no corresponding branch in respective partner repo, just the main branch is pulled to run tests.
  • Tested using dummy PR in staging repo & confirmed all secrets are redacted in workflow logs as expected.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo changed the title chore: Adjusts CI GitHub workflows so it works in staging repo as well chore: Adjust CI GitHub workflows so it works in staging repo as well Dec 17, 2024
@sichanyoo sichanyoo changed the title chore: Adjust CI GitHub workflows so it works in staging repo as well chore: Adjust CI GitHub workflows so it works in staging repo Dec 18, 2024
@sichanyoo sichanyoo changed the title chore: Adjust CI GitHub workflows so it works in staging repo chore: Make GH workflows pass in staging & refactor using composite actions Dec 18, 2024
@sichanyoo sichanyoo requested a review from jbelkins December 19, 2024 19:00
@sichanyoo sichanyoo merged commit fac5c3a into main Dec 24, 2024
27 checks passed
@sichanyoo sichanyoo deleted the ci/adjust-ci-for-staging branch December 24, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants