Neutralizing Gas and Extreme Weather abilities ending after switching out

[andrebastosdias]

@DaWoblefet :

When Neutralizing Gas leaves the field, the user is still relatively "active" on the field during the pending switchout (e.g. it can have its Attack dropped via Intimidate, its item revealed via Frisk, or its HP restored via Hospitality, even though it's not "on the field" anymore). So it's a bug in the same way that a Pokemon using Volt Switch shouldn't be "on the field" when choosing a target to be replaced.

Added the PostEnd event. The client should include the -switchout command (purely for aesthetic purposes).

Still missing the Volt Switch part.

[DaWoblefet]

This does not work. The Neutralizing Gas Pokemon is currently not receiving Intimidate drops or getting healed from Hospitality, as examples. You can add Hospitality to Eternatus and damage Weezing before switching to see that for yourself. That behavior is correct on master currently.

Assuming that part gets worked out, we would need to merge a client PR to handle the new switchout protocol message, or else all battles will have an error message printed indicating no support.

[andrebastosdias]

On the master branch, the Neutralizing Gas Pokémon is being affected by Intimidate before switching out, which shouldn't happen.

Let's set aside the fact that the Pokémon is still visually present on the field. In practice, the only issue with the current logic is that the Neutralizing Gas Pokémon is being influenced by abilities. If we simply bypass this and allow the other Pokémon to be affected by the abilities' effects, it should work.

Edit. the real problem, it is that we never let an active slot be null when it switches out or faints. We just bypass it by looking at its hp.

[DaWoblefet]

On the master branch, the Neutralizing Gas Pokémon is being affected by Intimidate before switching out, which shouldn't happen.

No, you've got it backwards - that is what should happen. The Weezing should have its Attack dropped by Intimidate before switching out. That particular interaction on master is correct right now.