-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Terastallize Ogerpon and Terapagos with different Tera types #10814
base: master
Are you sure you want to change the base?
Conversation
this.details = species.name + (this.level === 100 ? '' : ', L' + this.level) + | ||
let displayedSpeciesName = species.name; | ||
if (species.baseSpecies === 'Ogerpon' && this.terastallized && this.teraType !== species.forceTeraType) { | ||
switch (this.teraType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ik you're still in draft, but shouldn't this be species.forceTeraType
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to DaWoblefet
- Hacked Ogerpon-[form]-Tera forms will become whatever the Tera Type is for that Ogerpon.
- it will allow, for example, a Tera Water Ogerpon-Hearthflame (or Ogerpon-Hearthflame-Tera) holding Hearthflame Mask (Ogerpon-2) to Terastallize to Ogerpon-Wellspring-Tera (Ogerpon-5). Doing so will change Ogerpon to Water-type, but still give an Attack boost, and Ivy Cudgel will still be Fire-type.
Basically, if Ogerpon-Hearthflame Terastallizes into a Water type, its species becomes Ogerpon-Hearthflame-Tera, but its appearance changes to Ogerpon-Wellspring-Tera (and it becomes a Water type). In this case, the input of formChange
would be Ogerpon-Hearthflame-Tera (to handle the ability and the type of Ivy Cudgel), but the details
should be Ogerpon-Wellspring-Tera.
This is just a draft because I still have an open PR that will conflict with this (all the displayedSpeciesName
logic would be moved to a separate function that handles the details), but I think I'll put it for review.
"Due to how overworld weather works in Generation IX, Teraform Zero will fail to protect from its effects."
Terapagos
https://www.youtube.com/watch?v=g-eUP0IrxI0
Teraform Zero activates but doesn’t deactivate the weather or terrain. Instead, it sends a failure message.Due to how overworld weather works in Generation IX, Teraform Zero will fail to protect from its effects.Ogerpon
https://www.smogon.com/forums/threads/ogerpon-teal-tera-tera-can-exist.3742851/post-10132811
I added the
ruleTable.has('obtainablemisc')
condition in the TeamValidator to allow players to use Ogerpon and Terapagos with different Tera Types in Hackmons. The client would also need to support changing Tera Types in the builder (at least for Hackmons).