2.50: Some new features #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be compatible to upstream core
These two tests are already skipped for hpux, and one for win32. I'm assuming the same issue here.
There is currently no IPv6 support in Net::Ping relying on IPv4 only routines like sockaddr_in and inet_ntoa/aton. I've created a patch to support IPv6. It's 95% complete. I'm having issues calculating the ICMPv6 checksum. As you may know, the ICMPv6 checksum is different than ICMPv4 in that ICMPv6 uses a pseudo-header (much like TCP/UDP) for checksum calculation. How to find the source address if the user does not call bind() before actually sending the packet? Other than that, IPv4 remains the default and all tests result in the same output for me as they did before the patch. IPv6 ping now also works, only not with ICMPv6 as transport (due to aforementioned checksum issue). I'd like some help getting that last ICMPv6 checksum part resolved and get this IPv6 support added to Net::Ping. Signed-off-by: Reini Urban <rurban@cpanel.net> No ipv6 test and the hires test is failing.
Wrong sockaddr_in in ntop. Document changed $ip as hash. Add Changes All tests pass, but ipv6 tests missing. Need to check the ICMPv6 checksum and source address.
rurban
force-pushed
the
icmpv6
branch
2 times, most recently
from
f10d127 to
35dde4c
Compare
added 2 commits
April 16, 2016 15:16
Add the icmpv6 protocol,
Support named arguments for new: proto timeout data_size device tos ttl family
gateway host bind retrans pingstring source_verify
econnrefused IPV6_USE_MIN_MTU IPV6_RECVPATHMTU
Add the wakeonlan function
Add missing documentation, and t/601_pod-coverage.t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p5p didn't agree with your test reorganization, and they are default upstream.
So use their layout, but I added your new tests there.
This is the version in cperl since 5.22.2c, I've also added better Socket support there.
I've added the latest changes from p5p.
I would prefer to get co-maint, so I can maintain it better.
Development stalled in your branch and at p5p.