Merge pull request #359 from snap-cloud/frontend-bootstrap

WIP: Migrate frontend styles to bootstrap
snap-cloud · Aug 23, 2024 · 691d9c7 · 691d9c7
2 parents e28df80 + caf9cec
commit 691d9c7
Show file tree

Hide file tree

Showing 83 changed files with 1,550 additions and 318 deletions.
diff --git a/locales/ca.lua b/locales/ca.lua
@@ -78,7 +78,7 @@ local locale = {
     welcome_logged_in = "Hola, @1!", -- @1 becomes the current user username
     snap_description = "Snap@1 és un llenguatge àmpliament acollidor tant per a nens i nenes com per a adults, així com una plataforma per a un estudi rigorós de les ciències de la computació.",
     -- Buttons
-    run_now = "Obre Snap@1 ara",
+    run_now = "Obre @1 ara",
     -- examples and manual already translated in Footer
     -- Curated Collections
     featured = "Projectes destacats",

diff --git a/locales/en.lua b/locales/en.lua
@@ -79,7 +79,7 @@ local locale = {
     welcome_logged_in = "Welcome, @1!", -- @1 becomes the current user username
     snap_description = "Snap@1 is a broadly inviting programming language for kids and adults that's also a platform for serious study of computer science.",
     -- Buttons
-    run_now = "Run Snap@1 Now",
+    run_now = "Run @1 Now",
     -- examples and manual already translated in Footer
     -- Curated Collections
     featured = "Featured Projects",

diff --git a/locales/es.lua b/locales/es.lua
@@ -80,7 +80,7 @@ local locale = {
     welcome_logged_in = "¡Hola, @1!", -- @1 becomes the current user username
     snap_description = "Snap@1 es un lenguaje ámpliamente acogedor tanto para niños y niñas como para adultos, así como también una plataforma para un estudio riguroso de las ciencias de la computación.",
     -- Buttons
-    run_now = "Abre Snap@1 ahora",
+    run_now = "Abre @1 ahora",
     -- examples and manual already translated in Footer
     -- Curated Collections
     featured = "Proyectos destacados",

diff --git a/site.lua b/site.lua
@@ -33,7 +33,6 @@ local Projects = package.loaded.Projects
 local Remixes = package.loaded.Remixes
 local Collections = package.loaded.Collections
 local FlaggedProjects = package.loaded.FlaggedProjects
-local db = package.loaded.db
 local assert_exists = require('validation').assert_exists
 
 require 'controllers.user'
@@ -45,30 +44,52 @@ require 'dialogs'
 app:enable('etlua')
 app.layout = require 'views.layout'
 
-local views = {
-    -- Static pages
-    'about', 'bjc', 'coc', 'contact', 'credits', 'dmca', 'extensions',
+local static_pages = {
+    'about', 'bjc', 'blog', 'coc', 'contact', 'credits', 'dmca', 'extensions',
     'materials', 'mirrors', 'offline', 'partners', 'privacy', 'research',
-    'snapinator', 'snapp', 'source', 'tos',
+    'snapinator', 'snapp', 'source', 'tos'
+}
 
+local views = {
     -- Simple pages
-    'blog', 'change_email', 'change_password', 'delete_user', 'forgot_password',
-    'forgot_username', 'sign_up', 'login',
+    'change_email', 'change_password', 'delete_user', 'forgot_password',
+    'forgot_username', 'sign_up', 'login'
 }
 
+-- Temporary during a front-end rewrite.
+-- This allows testing anypage with adding ?bootstrap=true to the URL
+app:before_filter(function (self)
+    if self.current_user and self.current_user:isadmin() then
+        if self.params['bootstrap'] == 'true' then
+            app.layout = 'layout_bs'
+        end
+    end
+end)
+
 app:get('index', '/', capture_errors(cached(function (self)
     self.snapcloud_id = Users:find({ username = 'snapcloud' }).id
-    return { render = 'index' }
+    -- return { render = 'index' }
+    return { render = 'index_bs', layout = 'layout_bs' }
 end)))
 
 -- Backwards compatibility.
 app:get('/index', function ()
     return { redirect_to = '/' }
 end)
 
+for _, page in pairs(static_pages) do
+    app:get('/' .. page, capture_errors(cached(function (self)
+            return { render = 'static/' .. page, layout = 'layout_bs' }
+    end)))
+end
+
 for _, view in pairs(views) do
     app:get('/' .. view, capture_errors(cached(function (self)
-        return { render = view }
+        if self.params['bootstrap'] then
+            return { render = view .. '_bs', layout = 'layout_bs'}
+        else
+            return { render = view }
+        end
     end)))
 end
 
@@ -84,30 +105,30 @@ end))
 
 app:get('/explore', capture_errors(cached(function (self)
     self.items = ProjectController.fetch(self)
-    return { render = 'explore' }
+    return { render = 'explore', layout = 'layout_bs' }
 end)))
 
 app:get('/collections', capture_errors(cached(function (self)
     self.items = CollectionController.fetch(self)
-    return { render = 'collections' }
+    return { render = 'collections', layout = 'layout_bs' }
 end)))
 
 app:get('/all_totms', capture_errors(cached(function (self)
     self.items = CollectionController.totms(self)
-    return { render = 'all_totms' }
+    return { render = 'all_totms', layout = 'layout_bs' }
 end)))
 
 app:get('/users', capture_errors(cached(function (self)
     self.items_per_page = 51
     self.items = UserController.fetch(self)
     if not self.params.search_term then self.params.search_term = '' end
-    return { render = 'users' }
+    return { render = 'users', layout = 'layout_bs' }
 end)))
 
 app:get('/my_projects', capture_errors(function (self)
     if self.current_user then
         self.items = ProjectController.my_projects(self)
-        return { render = 'my_projects' }
+        return { render = 'my_projects', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -116,7 +137,7 @@ end))
 app:get('/my_collections', capture_errors(function (self)
     if self.current_user then
         self.items = CollectionController.my_collections(self)
-        return { render = 'my_collections' }
+        return { render = 'my_collections', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -153,20 +174,20 @@ app:get('/user', capture_errors(function (self)
     assert_user_exists(self)
     self.username = self.queried_user.username
     self.user_id = self.queried_user.id
-    return { render = 'user' }
+    return { render = 'user', layout = 'layout_bs' }
 end))
 
 app:get('/user_collections/:username', capture_errors(cached(function (self)
     assert_user_exists(self)
     self.params.user_id = self.queried_user.id
     self.items = CollectionController.user_collections(self)
-    return { render = 'collections' }
+    return { render = 'collections', layout = 'layout_bs' }
 end)))
 
 app:get('/user_projects/:username', capture_errors(cached(function (self)
     assert_user_exists(self)
     self.items = ProjectController.user_projects(self)
-    return { render = 'explore' }
+    return { render = 'explore', layout = 'layout_bs' }
 end)))
 
 -- Display an embedded collection view.
@@ -187,7 +208,7 @@ end)))
 app:get('/followed', capture_errors(cached(function (self)
     if self.current_user then
         self.items = ProjectController.followed_projects(self)
-        return { render = 'followed' }
+        return { render = 'followed', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -196,7 +217,7 @@ end)))
 app:get('/followed_users', capture_errors(cached(function (self)
     if self.current_user then
         self.items = UserController.followed_users(self)
-        return { render = 'followed_users' }
+        return { render = 'followed_users', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -205,7 +226,7 @@ end)))
 app:get('/my_followers', capture_errors(cached(function (self)
     if self.current_user then
         self.items = UserController.follower_users(self)
-        return { render = 'my_followers' }
+    return { render = 'my_followers', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -256,23 +277,23 @@ app:match('project', '/project', capture_errors(function (self)
     return { render = 'project' }
 end))
 
+-- TODO: Should be able to consolidate these pages.
 app:get('/examples', capture_errors(cached(function (self)
     self.snapcloud_id = Users:find({ username = 'snapcloud' }).id
-    return { render = 'examples' }
+    return { render = 'examples', layout = 'layout_bs' }
 end)))
 
 app:get('/events', capture_errors(cached(function (self)
     self.snapcloud_id = Users:find({ username = 'snapcloud' }).id
-    return { render = 'events' }
+    return { render = 'events', layout = 'layout_bs' }
 end)))
 
 app:get('/search', capture_errors(function (self)
     self.reviewer_controls =
         self.current_user and self.current_user:has_min_role('reviewer')
-    return { render = 'search' }
+    return { render = 'search', layout = 'layout_bs' }
 end))
 
--- Administration and data management pages
 
 app:get('/profile', capture_errors(function (self)
     if self.current_user then
@@ -283,10 +304,12 @@ app:get('/profile', capture_errors(function (self)
     end
 end))
 
+-- Administration and data management pages
+
 app:get('/admin', capture_errors(function (self)
     if self.current_user then
         assert_min_role(self, 'reviewer')
-        return { render = 'admin' }
+        return { render = 'admin/index', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -296,7 +319,7 @@ app:get('/flags', capture_errors(function (self)
     if self.current_user then
         assert_min_role(self, 'reviewer')
         items = ProjectController.flagged_projects(self)
-        return { render = 'flags' }
+        return { render = 'admin/flags' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -307,7 +330,7 @@ app:get('/user_admin', capture_errors(function (self)
     if self.current_user then
         assert_min_role(self, 'moderator')
         self.items = UserController.fetch(self)
-        return { render = 'user_admin' }
+        return { render = 'admin/user_admin', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('/') }
     end
@@ -318,17 +341,17 @@ app:get('/zombie_admin', capture_errors(function (self)
     if self.current_user then
         assert_min_role(self, 'moderator')
         self.items = UserController.zombies(self)
-        return { render = 'zombie_admin' }
+        return { render = 'admin/zombie_admin' }
     else
         return { redirect_to = self:build_url('/') }
     end
 end))
 
-app:match('/totm', respond_to({
+app:match('admin/totm', '/totm', respond_to({
     GET = capture_errors(function (self)
         if self.current_user then
             assert_min_role(self, 'moderator')
-            return { render = 'totm' }
+            return { render = true, layout = 'layout_bs' }
         else
             return { redirect_to = self:build_url('/') }
         end
@@ -339,7 +362,7 @@ app:match('/totm', respond_to({
         if file then
             local disk = package.loaded.disk
             if disk:save_totm_banner(file) then
-                return { render = 'totm' }
+                return { render = true, layout = 'layout_bs' }
             end
         end
         return errorResponse(self)
@@ -348,13 +371,13 @@ app:match('/totm', respond_to({
 
 app:get('/carousel_admin', capture_errors(function (self)
     assert_min_role(self, 'moderator')
-    return { render = 'carousel_admin' }
+    return { render = 'admin/carousel_admin' }
 end))
 
 app:get('/ip_admin', capture_errors(function (self)
     assert_min_role(self, 'admin')
     self.ips = SiteController.banned_ips(self)
-    return { render = 'ip_admin' }
+    return { render = 'admin/ip_admin' }
 end))
 
 -- Teachers
@@ -364,15 +387,15 @@ app:get('/teacher', capture_errors(function (self)
     if (not self.current_user.is_teacher) then
         assert_admin(self)
     end
-    return { render = 'teacher' }
+    return { render = 'teacher/index', layout = 'layout_bs' }
 end))
 
 app:get('/bulk', capture_errors(function (self)
     assert_exists(self.current_user)
     if (not self.current_user.is_teacher) then
         assert_admin(self)
     end
-    return { render = 'bulk' }
+    return { render = 'teacher/bulk', layout = 'layout_bs' }
 end))
 
 app:get('/learners', capture_errors(function (self)
@@ -384,14 +407,13 @@ app:get('/learners', capture_errors(function (self)
     self.items_per_page = 150
     if self.current_user and self.current_user.is_teacher then
         self.items = UserController.learners(self)
-        return { render = 'learners' }
+        return { render = 'teacher/learners', layout = 'layout_bs' }
     else
         return { redirect_to = self:build_url('index') }
     end
 end))
 
 -- Tools
-
 --[[
 app:get('/localize', capture_errors(function (self)
     return { render = 'localize' }

diff --git a/static/img/lowfloor.png b/static/img/lowfloor.png
diff --git a/static/js/base.js b/static/js/base.js
@@ -1,6 +1,5 @@
 var snapURL = location.origin + '/snap/snap.html',
     snapDevURL = location.origin + '/snapsource/dev/snap.html',
-    baseURL = location.protocol + '//' + location.host,
     nop = function () {},
     localizer = new Localizer(),
     buttonDefaults =
@@ -10,7 +9,7 @@ function encodeParams (params) {
     if (params) {
         return '?' +
             Object.keys(params).map(
-                paramName => 
+                paramName =>
                     encodeURIComponent(paramName) + '=' +
                         encodeURIComponent(JSON.stringify(params[paramName]))
             ).join('&');
@@ -95,6 +94,24 @@ function flash (element, callback, warning) {
     }, 500);
 };
 
+function setupCarouselPageIndicator (id) {
+    function setCarouselText(carousel, current, total) {
+        let textContainer = carousel.querySelector('.js-textStatus');
+        textContainer.querySelector('.page-link').innerHTML = `${current} / ${total}`;
+        textContainer.querySelector('.visually-hidden').innerHTML = `${current} of ${total}`;
+    }
+
+    let carousel = document.getElementById(`${id}_container`);
+    let totalItems = carousel.querySelectorAll('.carousel-item').length;
+    let currentIndex = Array.prototype.indexOf.call(carousel.querySelectorAll('.carousel-item'), carousel.querySelector('div.active')) + 1;
+    setCarouselText(carousel, currentIndex, totalItems);
+
+    carousel.addEventListener('slid.bs.carousel', function() {
+        currentIndex = Array.prototype.indexOf.call(carousel.querySelectorAll('.carousel-item'), carousel.querySelector('div.active')) + 1;
+        setCarouselText(carousel, currentIndex, totalItems);
+    });
+};
+
 // JS additions
 
 Array.prototype.sortBy = function (parameter, reverse) {