Skip to content

Commit

Permalink
use configmap instead of secret
Browse files Browse the repository at this point in the history
  • Loading branch information
therealak12 committed Feb 21, 2024
1 parent eb69d08 commit 775ac71
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 23 deletions.
7 changes: 7 additions & 0 deletions clients/harbor-client/charts/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Values.configMapName }}
namespace: {{ .Release.Namespace }}
data:
IMAGE_REFERENCE: "{{ .Values.imageReference }}"
4 changes: 2 additions & 2 deletions clients/harbor-client/charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ spec:
env:
- name: IMAGE_REFERENCE
valueFrom:
secretKeyRef:
name: {{ .Values.configSecretName }}
configMapKeyRef:
name: {{ .Values.configMapName }}
key: IMAGE_REFERENCE
resources:
{{- toYaml .Values.resources | nindent 12 }}
7 changes: 0 additions & 7 deletions clients/harbor-client/charts/templates/secret.yaml

This file was deleted.

4 changes: 3 additions & 1 deletion clients/harbor-client/charts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ autoscaling:
maxReplicas: 100
targetCPUUtilizationPercentage: 80

configSecretName: spcld-harbor-health-client
configMapName: spcld-harbor-health-client

imageReference: registry.com/repo/image:latest
6 changes: 6 additions & 0 deletions clients/proxy-client/charts/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Values.configMapName }}
data:
PROXY_URL: "{{ .Values.proxyUrl }}"
4 changes: 2 additions & 2 deletions clients/proxy-client/charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ spec:
env:
- name: PROXY_URL
valueFrom:
secretKeyRef:
name: {{ .Values.configSecretName }}
configMapKeyRef:
name: {{ .Values.configMapName }}
key: PROXY_URL
resources:
{{- toYaml .Values.resources | nindent 12 }}
7 changes: 0 additions & 7 deletions clients/proxy-client/charts/templates/secret.yaml

This file was deleted.

10 changes: 6 additions & 4 deletions clients/proxy-client/charts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ image:
pullPolicy: Always
tag: "0.1.0"

imagePullSecrets: []
imagePullSecrets: [ ]
nameOverride: ""
fullnameOverride: ""

podAnnotations: {}
podLabels: {}
podAnnotations: { }
podLabels: { }

service:
type: ClusterIP
Expand All @@ -30,4 +30,6 @@ autoscaling:
maxReplicas: 100
targetCPUUtilizationPercentage: 80

configSecretName: spcld-proxy-health-client
configMapName: spcld-proxy-health-client

proxyUrl: proxy.url

0 comments on commit 775ac71

Please sign in to comment.