feat: rename file #102
Merged
feat: rename file #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolotskydev
requested changes
Jul 30, 2021
Comment on lines
98
to
102
| let newData = cloneDeep(files); | ||
| newData = newData.map((item) => | ||
| item.id === fileId ? { ...item, data: { ...item.data, name: newName } } : item | ||
| ); | ||
| return { files: newData }; |
There was a problem hiding this comment.
what is the reason of deep clone here? right below you are essentially recreating the whole thing anyway 🤔
There was a problem hiding this comment.
I reworked this totally, review again, please.
templates/frontend/src/components/shared/file-browser/folder/folder.jsx
Outdated
Show resolved
Hide resolved
|
@lxkuz thanks for contribution! Made some nitpicks, otherwise LGTM! GJ 👏 |
bolotskydev
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what changes this pull request brings
Covering #92 we add a dropdown to the file with
DeleteandRenameoptions.Describe any additional changes
Rename modal is generalized and now supports both file and folder.
Steps to test
Screenshots
Checklist
TODO
References
Issue #92