Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1524257 Implement GCM encryption #1191

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

SNOW-1524257 Implemented GCM encryption to be ready for CSP integrations.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

gitguardian bot commented Aug 1, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 2, 2024 05:25
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 2, 2024 05:25
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 64.96350% with 48 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (1a90e21) to head (5b13f38).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
encrypt_util.go 63.90% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
- Coverage   82.79%   82.57%   -0.22%     
==========================================
  Files          55       55              
  Lines       13194    13315     +121     
==========================================
+ Hits        10924    10995      +71     
- Misses       2270     2320      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus merged commit e45a36b into master Oct 28, 2024
37 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1524257-gcm-encryption branch October 28, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants