Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1671768] Ignore max retries error when getting acelerate config #1212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfc-gh-astachowski
Copy link
Contributor

Description

Added max retries error to errors ignored when getting acceleration config.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner September 20, 2024 09:40
Copy link

@sfc-gh-hyu sfc-gh-hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general preference is that: we only enable bucket acceleration configuration is we are able to get bucket configuration and bucket configuration indeed returns that acceleration is enabled for the bucket, in all other scenarios, whatever error returned by http, we just fallback to treating that bucket acceleration is not enabled. This is a much robust way. And this is how python connector handler the error as well. Check the code here https://github.com/snowflakedb/snowflake-connector-python/blob/3c8255935b9aebc2edee8de3913959f86596739f/src/snowflake/connector/s3_storage_client.py#L583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants