Skip to content

Commit

Permalink
SNOW-1055755: windows build debug - ...wix util schema update - min test
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-mraba committed Sep 9, 2024
1 parent c3d74ba commit 4f4a12a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
18 changes: 18 additions & 0 deletions scripts/packaging/win/snowflake_cli_min.wxs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?xml version='1.0' encoding='utf-8'?>
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:util="http://wixtoolset.org/schemas/v4/wxs/util">
<Package Name="Snowflake CLI" Language="1033" Version="$(var.SnowflakeCLIVersion)" Manufacturer="Snowflake, Inc." UpgradeCode="42280567-AE10-4184-8BB4-F98F59519CB2" InstallerVersion="405">
<SummaryInformation Manufacturer="Snowflake, Inc." />
<WixVariable Id="WixUIDialogBmp" Value="scripts\packaging\win\snowflake_msi_background.png" />
<WixVariable Id="WixUIBannerBmp" Value="scripts\packaging\win\snowflake_msi_banner.png" />
<Media Id="1" Cabinet="snow.cab" EmbedCab="yes" />
<MajorUpgrade AllowDowngrades="yes" />
<Files Include="..\..\..\dist\snow\**" />
<Icon Id="icon.ico" SourceFile="scripts\packaging\win\snowflake_msi.ico" />
<Property Id="ARPPRODUCTICON" Value="icon.ico" />
<Property Id="ARPHELPLINK" Value="https://docs.snowflake.net/manuals/user-guide/snowflake-cli.html" />
<Property Id="ARPNOMODIFY" Value="yes" Secure="yes" />
<Property Id="ARPURLINFOABOUT" Value="https://snowflake.com/" />
<Property Id="ApplicationFolderName" Value="Snowflake CLI" />
<Property Id="WixAppFolder" Value="WixUISupportPerUser" />
</Package>
</Wix>
2 changes: 1 addition & 1 deletion scripts/packaging/win/wxs_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
ElementTree.register_namespace(ns_name, ns_url)
wxs = ElementTree.parse(WXS_TEMPLATE_FILE)
root = wxs.getroot()
snow_files = root.find(".//Component", namespaces=ns)
snow_files = root.find(".//DirectoryRef", namespaces=ns)
if snow_files is None:
raise ValueError("Component not found in the template")

Expand Down

0 comments on commit 4f4a12a

Please sign in to comment.