Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions and default values in generation of project definition #1296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add descriptions and default values in generation of project definition #1296

wants to merge 1 commit into from

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

  • Add descriptions for each field in NativeApp definition
  • Add default values to project definition file
  • Add Enum value to safe references.

Todo:

  • Add descriptions for snowpark and streamlit

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas changed the title Add description for nativeapp and default values Add descriptions and default values in generation of project definition Jul 8, 2024
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas changed the title Add descriptions and default values in generation of project definition PoC Add descriptions and default values in generation of project definition Jul 8, 2024
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review July 29, 2024 16:39
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) July 31, 2024 08:33
@sfc-gh-turbaszek
Copy link
Collaborator

@sfc-gh-jvasquezrojas can you rebase please?

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas changed the title PoC Add descriptions and default values in generation of project definition Add descriptions and default values in generation of project definition Aug 13, 2024
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the add_descriptions_to_project_definition branch from a182d5e to 890adfd Compare August 14, 2024 03:57
@sfc-gh-bdufour
Copy link
Contributor

My overall .02: this PR doesn't include sufficient context for me to understand why the CLI team is doing this work. Please update the description (and checklist too) to include more context. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jvasquezrojas @sfc-gh-turbaszek @sfc-gh-bdufour